From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116403 invoked by alias); 19 Oct 2015 09:35:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116393 invoked by uid 89); 19 Oct 2015 09:35:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 19 Oct 2015 09:35:48 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 6865BC0C1899; Mon, 19 Oct 2015 09:35:47 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9J9Zjgp001494; Mon, 19 Oct 2015 05:35:46 -0400 Message-ID: <5624B971.4090403@redhat.com> Date: Mon, 19 Oct 2015 09:35:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org, Yao Qi Subject: Re: [PATCH v2 4/7] Support breakpoint kinds for software breakpoints in GDBServer. References: <1444063455-31558-1-git-send-email-antoine.tremblay@ericsson.com> <1444063455-31558-5-git-send-email-antoine.tremblay@ericsson.com> <561FCB85.4020500@redhat.com> <561FEA3A.5020801@ericsson.com> <56212081.5090703@redhat.com> <56213D20.8090803@ericsson.com> <56214A33.5060109@redhat.com> <56214EC0.9070806@ericsson.com> <56215380.7070908@ericsson.com> In-Reply-To: <56215380.7070908@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00329.txt.bz2 On 10/16/2015 08:44 PM, Antoine Tremblay wrote: > Humm thinking more about it however if we were to apply the same logic > to pc and pcfull. > > Removing the pc from the struct would cause a call to > breakpoint_kind_from_pc to be mandatory. > > Would you see too pc to be removed ? > I was seeing pcfull being removed, actually. Z0 breakpoints always have their address already adjusted by GDB, right? You had: @@ -774,9 +802,15 @@ set_breakpoint_at (CORE_ADDR where, int (*handler) (CORE_ADDR)) { int err_ignored; + const unsigned char *breakpoint_data; + int breakpoint_len; + CORE_ADDR pc = where; + + breakpoint_data = the_target->breakpoint_from_pc (&pc, &breakpoint_len); + return set_breakpoint (other_breakpoint, raw_bkpt_type_sw, - where, breakpoint_len, handler, - &err_ignored); + where, pc, breakpoint_data, breakpoint_len, + breakpoint_len, handler, &err_ignored); } But I think you should be able to instead do: @@ -774,9 +802,15 @@ set_breakpoint_at (CORE_ADDR where, int (*handler) (CORE_ADDR)) { int err_ignored; + CORE_ADDR adjusted_pc = where; + int bp_kind; + + bp_kind = the_target->breakpoint_kind_from_pc (&adjusted_pc); + return set_breakpoint (other_breakpoint, raw_bkpt_type_sw, - where, breakpoint_len, handler, + adjusted_pc, bp_kind, handler, &err_ignored); } Thanks, Pedro Alves