From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58031 invoked by alias); 16 Oct 2015 12:11:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58017 invoked by uid 89); 16 Oct 2015 12:11:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 16 Oct 2015 12:11:45 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 8B71C319B49; Fri, 16 Oct 2015 12:11:44 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9GCBg7k006039; Fri, 16 Oct 2015 08:11:43 -0400 Message-ID: <5620E97E.3010003@redhat.com> Date: Fri, 16 Oct 2015 12:11:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yao Qi , Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH v2 7/7] Support software breakpoints for ARM linux in GDBServer. References: <1444063455-31558-1-git-send-email-antoine.tremblay@ericsson.com> <1444063455-31558-8-git-send-email-antoine.tremblay@ericsson.com> <561FCF40.1010107@redhat.com> <5620C3C7.5050504@gmail.com> In-Reply-To: <5620C3C7.5050504@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00276.txt.bz2 On 10/16/2015 10:30 AM, Yao Qi wrote: > On 15/10/15 17:07, Pedro Alves wrote: >>> +* Support for software breakpoints on ARM linux was added in GDBServer. >> Putting a user hat on, what does this mean? Why is it news worthy? >> > > Supporting software breakpoint on ARM Linux GDBserver isn't user > visible, but isn't it a user-visible change that ARM Linux GDBserver > supports Z0 packet? How can the user tell? Is there any user-visible functionality or feature that this enables? Something the user couldn't do before but now can? It just looks like an implementation detail to me. If we're going to mention it, then I think it should be described in terms of the packet, otherwise we're back to "but I could always set software breakpoints before, what's new?". BTW, I think we should move all the new gdbserver features to a new section, like in previous releases. Then the end result would be something like: * New features in the GDB remote stub, GDBserver ** Support for software breakpoint packets (Z0) on ARM Linux. ** Support for tracepoints on Aarch64 Linux. ** Support for fast tracepoints on Aarch64 Linux, including JIT compiling fast tracepoint's conditional expression bytecode into native code. Thanks, Pedro Alves