From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8783 invoked by alias); 15 Oct 2015 18:24:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8773 invoked by uid 89); 15 Oct 2015 18:24:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 15 Oct 2015 18:23:59 +0000 Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 25.B2.26730.1D28F165; Thu, 15 Oct 2015 12:41:22 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.80) with Microsoft SMTP Server id 14.3.248.2; Thu, 15 Oct 2015 14:23:56 -0400 Subject: Re: [PATCH v2 7/7] Support software breakpoints for ARM linux in GDBServer. To: Pedro Alves , References: <1444063455-31558-1-git-send-email-antoine.tremblay@ericsson.com> <1444063455-31558-8-git-send-email-antoine.tremblay@ericsson.com> <561FCF40.1010107@redhat.com> From: Antoine Tremblay Message-ID: <561FEF3C.7060200@ericsson.com> Date: Thu, 15 Oct 2015 18:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <561FCF40.1010107@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00271.txt.bz2 On 10/15/2015 12:07 PM, Pedro Alves wrote: > On 10/05/2015 05:44 PM, Antoine Tremblay wrote: > >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -3,6 +3,8 @@ >> >> *** Changes since GDB 7.10 >> >> +* Support for software breakpoints on ARM linux was added in GDBServer. > > Putting a user hat on, what does this mean? Why is it news worthy? > Humm I had not thought about it this way would saying something like : * Support for software breakpoints on ARM linux was added in GDBServer. Users can now call break to set a breakpoint with GDBServer on ARM linux. Be better ? >> + >> * Record btrace now supports non-stop mode. >> >> * Support for tracepoints on aarch64-linux was added in GDBserver. >> diff --git a/gdb/gdbserver/linux-arm-low.c b/gdb/gdbserver/linux-arm-low.c >> index d16ea60..bd499f8 100644 >> --- a/gdb/gdbserver/linux-arm-low.c >> +++ b/gdb/gdbserver/linux-arm-low.c >> @@ -336,6 +336,28 @@ arm_breakpoint_from_pc (CORE_ADDR *pcptr, int *lenptr) >> } >> } >> >> +/* Get the breakpoint from the remote kind >> + 2 is thumb-16 >> + 3 is thumb2-32 >> + 4 is arm >> +*/ >> +static const unsigned char * >> +arm_breakpoint_from_kind (int *kind) >> +{ >> + switch (*kind) { >> + case 2: > > Formatting, break line before {, indent case. > Indeed seems like the switch case indent was not in the Emacs GNU default config Done.