Re: [PATCH 3/3] (patch 2/4, v2) [nto] Implement procfs_pid_to_exec_file.

Aleksandar Ristovski
2015-10-20T17:14:54Z

On 15-10-20 11:24 AM, Pedro Alves wrote:
> On 10/20/2015 03:28 PM, Aleksandar Ristovski wrote:
>> gdb/ChangeLog:
>>
>> * gdb/nto-procfs.c (procfs_pid_to_exec_file): New function.
>> (init_procfs_targets): Wire new function.
>> ---
>> gdb/nto-procfs.c | 28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/gdb/nto-procfs.c b/gdb/nto-procfs.c
>> index ac54c32..e7882ba 100644
>> --- a/gdb/nto-procfs.c
>> +++ b/gdb/nto-procfs.c
>> @@ -617,6 +617,33 @@ procfs_files_info (struct target_ops *ignore)
>> (nodestr != NULL) ? nodestr : "local node");
>> }
>>
>> +/* Read executable file name for the given PID. */
>> +
>
> Please write instead:
>
> /* Target to_pid_to_exec_file implementation. */
>
>> +static char *
>> +procfs_pid_to_exec_file (struct target_ops *ops, const int pid)
>> +{
>
> OK with that change.
>
> Thanks,
> Pedro Alves
>
>

Pushed with:

+/* Target to_pid_to_exec_file implementation. */
+
+static char *
+procfs_pid_to_exec_file (struct target_ops *ops, const int pid)

Thank you,

Aleksandar Ristovski