From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19432 invoked by alias); 15 Oct 2015 17:34:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19422 invoked by uid 89); 15 Oct 2015 17:33:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 15 Oct 2015 17:33:58 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 98F24C0A1472; Thu, 15 Oct 2015 17:33:57 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9FHXtYB028186; Thu, 15 Oct 2015 13:33:56 -0400 Message-ID: <561FE383.3030601@redhat.com> Date: Thu, 15 Oct 2015 17:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Aleksandar Ristovski , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] [nto] Fix nto build. References: <1444752074-878-1-git-send-email-aristovski@qnx.com> <1444752074-878-2-git-send-email-aristovski@qnx.com> In-Reply-To: <1444752074-878-2-git-send-email-aristovski@qnx.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00267.txt.bz2 On 10/13/2015 05:01 PM, Aleksandar Ristovski wrote: > gdb/gdbserver/ChangeLog: > > * gdbserver/nto-low.c (nto_insert_point, nto_remove_point): Fix > variable name. > > gdb/ChangeLog: > > * nto-procfs.c (common/filestuff.h): Include. > (procfs_can_use_hw_breakpoint): Fix enum name. > (procfs_open_1): Fix compiler warning. > (procfs_pidlist): Make static. > (procfs_meminfo): Make static, fix type name, add missing argument. > (procfs_store_registers): Make static. > (procfs_thread_info): Remove unused function. > (_initialize_procfs): Forward declare. LGTM. Thanks, Pedro Alves