From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54736 invoked by alias); 15 Oct 2015 17:13:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54723 invoked by uid 89); 15 Oct 2015 17:13:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 15 Oct 2015 17:13:23 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 48.FD.26730.5427F165; Thu, 15 Oct 2015 11:30:46 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.248.2; Thu, 15 Oct 2015 13:13:17 -0400 Subject: Re: [PATCH v2 3/7] Implement breakpoint_from_kind for supported architectures in GDBServer. To: Yao Qi References: <1444063455-31558-1-git-send-email-antoine.tremblay@ericsson.com> <1444063455-31558-4-git-send-email-antoine.tremblay@ericsson.com> <86y4f432w2.fsf@gmail.com> <561F869D.5040005@ericsson.com> CC: From: Antoine Tremblay Message-ID: <561FDEAD.4070502@ericsson.com> Date: Thu, 15 Oct 2015 17:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <561F869D.5040005@ericsson.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00260.txt.bz2 On 10/15/2015 06:57 AM, Antoine Tremblay wrote: > > > On 10/15/2015 05:19 AM, Yao Qi wrote: >> Antoine Tremblay writes: >> >> There is no changelog entry. >> > Wow sorry adding it. > >>> +/* Implementation of linux_target_ops method >>> "breakpoint_from_kind". */ >>> + >>> +static const unsigned char * >>> +aarch64_breakpoint_from_kind (int *kind) >>> +{ >>> + return (const unsigned char *) &aarch64_breakpoint; >> >> Indentation looks odd, and do we really need the cast? >> > > Fixed. Note this was changed to gdb_byte the cast is removed and aarch64_breakpoint is returned not &aarch64_breakpoint... > >> Note that this function is correct because we restrict the usage of Z0 >> packet. Z0 packet is only used with non-extended protocol and inferior >> is 64bit. See aarch64_supports_z_point_type. Once we remove the >> restriction, we need to update this function to return different >> breakpoint instructions (aarch64, arm, thumb, and thumb2) according to >> *KIND and other information. > > Yes indeed. > >> >> Otherwise, patch is OK to me. >>