From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71729 invoked by alias); 15 Oct 2015 16:22:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71717 invoked by uid 89); 15 Oct 2015 16:22:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 15 Oct 2015 16:22:13 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 716FDC0BB283; Thu, 15 Oct 2015 16:22:12 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9FGMASb012382; Thu, 15 Oct 2015 12:22:11 -0400 Message-ID: <561FD2B2.6070509@redhat.com> Date: Thu, 15 Oct 2015 16:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Aleksandar Ristovski , gdb-patches@sourceware.org Subject: Re: [PATCH] gdbserver: Reset current_thread when its process is removed. References: <1444919808-22088-1-git-send-email-aristovski@qnx.com> In-Reply-To: <1444919808-22088-1-git-send-email-aristovski@qnx.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00256.txt.bz2 On 10/15/2015 03:36 PM, Aleksandar Ristovski wrote: > In case of running gdbserver with --multi, if a nat file > removes a process, current_thread may remain set to now > freed 'process' entry. > > This may lead to wrong operation or a crash. > > gdb/gdbserver/ChangeLog: > * inferiors.c (remove_process): Reset current_thread if its > associated process gets removed. > --- > gdb/gdbserver/inferiors.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gdb/gdbserver/inferiors.c b/gdb/gdbserver/inferiors.c > index 21f45fa..4688a44 100644 > --- a/gdb/gdbserver/inferiors.c > +++ b/gdb/gdbserver/inferiors.c > @@ -291,6 +291,11 @@ remove_process (struct process_info *process) > { > clear_symbol_cache (&process->symbol_cache); > free_all_breakpoints (process); > + if (current_thread && get_thread_process (current_thread) == process) > + { > + remove_thread (current_thread); > + current_thread = NULL; > + } This seems very papering-over-something-else. - I could argue that current_thread = NULL would be better done inside remove_thread than here, since what you say would happen as well if the current thread is removed, even without removing the process. - And then, if we remove the current thread, why not remove others? AFAICS, other targets remove threads from within target_mourn, as that way they have a chance of clearing auxiliary info associated with the threads (the inferior_target_data()), and then some call clear_inferiors, which also clears current_thread. > remove_inferior (&all_processes, &process->entry); > free (process); > } > Thanks, Pedro Alves