From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24322 invoked by alias); 15 Oct 2015 16:07:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24295 invoked by uid 89); 15 Oct 2015 16:07:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 15 Oct 2015 16:07:31 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 74642C0BFD3C; Thu, 15 Oct 2015 16:07:30 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9FG7TwT004127; Thu, 15 Oct 2015 12:07:29 -0400 Message-ID: <561FCF40.1010107@redhat.com> Date: Thu, 15 Oct 2015 16:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH v2 7/7] Support software breakpoints for ARM linux in GDBServer. References: <1444063455-31558-1-git-send-email-antoine.tremblay@ericsson.com> <1444063455-31558-8-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1444063455-31558-8-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00253.txt.bz2 On 10/05/2015 05:44 PM, Antoine Tremblay wrote: > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,8 @@ > > *** Changes since GDB 7.10 > > +* Support for software breakpoints on ARM linux was added in GDBServer. Putting a user hat on, what does this mean? Why is it news worthy? > + > * Record btrace now supports non-stop mode. > > * Support for tracepoints on aarch64-linux was added in GDBserver. > diff --git a/gdb/gdbserver/linux-arm-low.c b/gdb/gdbserver/linux-arm-low.c > index d16ea60..bd499f8 100644 > --- a/gdb/gdbserver/linux-arm-low.c > +++ b/gdb/gdbserver/linux-arm-low.c > @@ -336,6 +336,28 @@ arm_breakpoint_from_pc (CORE_ADDR *pcptr, int *lenptr) > } > } > > +/* Get the breakpoint from the remote kind > + 2 is thumb-16 > + 3 is thumb2-32 > + 4 is arm > +*/ > +static const unsigned char * > +arm_breakpoint_from_kind (int *kind) > +{ > + switch (*kind) { > + case 2: Formatting, break line before {, indent case. > + return (unsigned char *) &thumb_breakpoint; > + case 3: > + *kind = 4; > + return (unsigned char *) &thumb2_breakpoint; > + case 4: > + return (unsigned char *) &arm_breakpoint; > + default: > + return NULL; > + } > + return NULL; > +} > + Thanks, Pedro Alves