From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88880 invoked by alias); 15 Oct 2015 15:33:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88870 invoked by uid 89); 15 Oct 2015 15:33:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 15 Oct 2015 15:33:47 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id CA50D2653; Thu, 15 Oct 2015 15:33:46 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9FFXiKY031006; Thu, 15 Oct 2015 11:33:45 -0400 Message-ID: <561FC758.4020301@redhat.com> Date: Thu, 15 Oct 2015 15:33:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/7] Add breakpoint_from_pc target_ops for software breakpoints in GDBServer. References: <1444063455-31558-1-git-send-email-antoine.tremblay@ericsson.com> <1444063455-31558-2-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1444063455-31558-2-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00248.txt.bz2 On 10/05/2015 05:44 PM, Antoine Tremblay wrote: > +static const unsigned char * gdb_byte? > +aarch64_breakpoint_from_pc (CORE_ADDR *pcptr, int *len) > +{ > + *len = aarch64_breakpoint_len; > + return (const unsigned char *) &aarch64_breakpoint; ... and then this cast goes away. > +} > + > +static const unsigned char * > +arm_breakpoint_from_pc (CORE_ADDR *pcptr, int *len) > +{ Missing '/* Implementation of ... */' comment. > +} > struct linux_target_ops the_low_target = { Missing empty line. > + > + /* Return the raw breakpoint for this target based on PC. The PCPTR is > + ajusted to the real memory location in case a flag was present in the "adjusted". Suggest an example, like "a flag (e.g., the Thumb bit on ARM) was" > + PC. */ > + const unsigned char *(*breakpoint_from_pc) (CORE_ADDR *pcptr, int *lenptr); Thanks, Pedro Alves