From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92139 invoked by alias); 13 Oct 2015 17:32:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92125 invoked by uid 89); 13 Oct 2015 17:32:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 13 Oct 2015 17:32:21 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 0182AA0BAE; Tue, 13 Oct 2015 17:32:19 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9DHWIHD024581; Tue, 13 Oct 2015 13:32:19 -0400 Message-ID: <561D4022.8010407@redhat.com> Date: Tue, 13 Oct 2015 17:32:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH c++ 1/5] lm32: Add (const gdb_byte *) cast References: <1444538238-7468-1-git-send-email-simon.marchi@polymtl.ca> <561B952D.8060909@redhat.com> <561D3BEB.9090409@ericsson.com> In-Reply-To: <561D3BEB.9090409@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00187.txt.bz2 On 10/13/2015 06:14 PM, Simon Marchi wrote: > On 15-10-12 07:10 AM, Pedro Alves wrote: >> This reveals that the code has a host-dependency. It is assuming the >> byte order of the target is the same as host's. >> >> Please replace this with a call to write_memory_unsigned_integer. >> >> Looks like this port hasn't been touched ever since it was >> originally contributed. Jon, is there still interest in this port? >> >> Thanks, >> Pedro Alves > > Ah, thanks for the tip. It would look like this then: Looks good. Thanks, Pedro Alves