From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56400 invoked by alias); 12 Oct 2015 16:43:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56286 invoked by uid 89); 12 Oct 2015 16:43:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f179.google.com Received: from mail-ig0-f179.google.com (HELO mail-ig0-f179.google.com) (209.85.213.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 12 Oct 2015 16:43:50 +0000 Received: by igbni9 with SMTP id ni9so41939811igb.1 for ; Mon, 12 Oct 2015 09:43:48 -0700 (PDT) X-Received: by 10.50.20.38 with SMTP id k6mr6603705ige.97.1444668228336; Mon, 12 Oct 2015 09:43:48 -0700 (PDT) Received: from [10.0.0.11] (cable-192.222.137.139.electronicbox.net. [192.222.137.139]) by smtp.gmail.com with ESMTPSA id m25sm7197532iod.32.2015.10.12.09.43.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Oct 2015 09:43:47 -0700 (PDT) Subject: Re: [PATCH c++ 3/5] mep: Add cast for int to enum conversion To: Yao Qi , Simon Marchi References: <1444538238-7468-1-git-send-email-simon.marchi@polymtl.ca> <1444538238-7468-3-git-send-email-simon.marchi@polymtl.ca> <86io6c5q9h.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Simon Marchi Message-ID: <561BE342.5050005@gmail.com> Date: Mon, 12 Oct 2015 16:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <86io6c5q9h.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00163.txt.bz2 On 12/10/15 06:34 AM, Yao Qi wrote: > Simon Marchi writes: > > Hi Simon, > Patch is OK, one nit below, > >> @@ -2396,7 +2396,10 @@ mep_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) >> /* The way to get the me_module code depends on the object file >> format. At the moment, we only know how to handle ELF. */ >> if (bfd_get_flavour (info.abfd) == bfd_target_elf_flavour) >> - me_module = elf_elfheader (info.abfd)->e_flags & EF_MEP_INDEX_MASK; >> + { >> + int flag = elf_elfheader (info.abfd)->e_flags & EF_MEP_INDEX_MASK; > > A blank line is needed here. > >> + me_module = (CONFIG_ATTR) flag; >> + } >> else >> me_module = CONFIG_NONE; >> } > Thanks, pushed with the newline.