Re: [PATCH c++ 1/5] lm32: Add (const gdb_byte *) cast

Simon Marchi
2015-10-21T18:44:35Z

On 15-10-11 12:37 AM, Simon Marchi wrote:
> There might be a cleaner sequence of function calls to do what is done
> here (I don't know), but since I don't want to risk breaking anything,
> it's safer to just add the required cast.
>
> gdb/ChangeLog:
>
> * lm32-tdep.c (lm32_push_dummy_call): Add cast.
> ---
> gdb/lm32-tdep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/lm32-tdep.c b/gdb/lm32-tdep.c
> index 25a7e1e..a0defad 100644
> --- a/gdb/lm32-tdep.c
> +++ b/gdb/lm32-tdep.c
> @@ -289,7 +289,7 @@ lm32_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
> regcache_cooked_write_unsigned (regcache, first_arg_reg + i, val);
> else
> {
> - write_memory (sp, (void *) &val, TYPE_LENGTH (arg_type));
> + write_memory (sp, (const gdb_byte *) &val, TYPE_LENGTH (arg_type));
> sp -= 4;
> }
> }
>

Ping for patches 1 and 4.