From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-126594-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 89861 invoked by alias); 12 Oct 2015 16:26:32 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 89849 invoked by uid 89); 12 Oct 2015 16:26:31 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-ig0-f178.google.com
Received: from mail-ig0-f178.google.com (HELO mail-ig0-f178.google.com) (209.85.213.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 12 Oct 2015 16:26:30 +0000
Received: by igbni9 with SMTP id ni9so41648953igb.1        for <gdb-patches@sourceware.org>; Mon, 12 Oct 2015 09:26:29 -0700 (PDT)
X-Received: by 10.50.61.148 with SMTP id p20mr13289591igr.81.1444667188888;        Mon, 12 Oct 2015 09:26:28 -0700 (PDT)
Received: from [10.0.0.11] (cable-192.222.137.139.electronicbox.net. [192.222.137.139])        by smtp.gmail.com with ESMTPSA id v10sm5107766igh.12.2015.10.12.09.26.27        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Mon, 12 Oct 2015 09:26:28 -0700 (PDT)
Subject: Re: [PATCH c++ 5/6] aarch64: Use gdb_sys_no_syscall enum instead of -1
To: Yao Qi <qiyaoltc@gmail.com>, Simon Marchi <simon.marchi@polymtl.ca>
References: <1444624329-4828-1-git-send-email-simon.marchi@polymtl.ca> <1444624329-4828-5-git-send-email-simon.marchi@polymtl.ca> <86vbac5rsx.fsf@gmail.com>
Cc: gdb-patches@sourceware.org
From: Simon Marchi <thundersim@gmail.com>
Message-ID: <561BDF32.4010307@gmail.com>
Date: Mon, 12 Oct 2015 16:26:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <86vbac5rsx.fsf@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-SW-Source: 2015-10/txt/msg00158.txt.bz2



On 12/10/15 06:01 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
>> Fixes:
>>
>> /home/simark/src/binutils-gdb/gdb/aarch64-linux-tdep.c: In function ‘gdb_syscall aarch64_canonicalize_syscall(aarch64_syscall)’:
>> /home/simark/src/binutils-gdb/gdb/aarch64-linux-tdep.c:874:13: error: invalid conversion from ‘int’ to ‘gdb_syscall’ [-fpermissive]
>>      return -1;
>>              ^
>>
>> gdb/ChangeLog:
>>
>> 	* aarch64-linux-tdep.c (aarch64_canonicalize_syscall): Return
>> 	gdb_sys_no_syscall instead of -1.
> 
> Patch is OK.
> 

Pushed, thanks!