From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11163 invoked by alias); 12 Oct 2015 10:54:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11150 invoked by uid 89); 12 Oct 2015 10:54:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 12 Oct 2015 10:54:35 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 5090A74; Mon, 12 Oct 2015 10:54:34 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9CAsUcm010183; Mon, 12 Oct 2015 06:54:33 -0400 Message-ID: <561B9166.7090101@redhat.com> Date: Mon, 12 Oct 2015 10:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH c++ 5/5] mips: Add cast for int to enum conversion References: <1444538238-7468-1-git-send-email-simon.marchi@polymtl.ca> <1444538238-7468-5-git-send-email-simon.marchi@polymtl.ca> In-Reply-To: <1444538238-7468-5-git-send-email-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-10/txt/msg00151.txt.bz2 On 10/11/2015 05:37 AM, Simon Marchi wrote: > This patch is taken directly from Pedro's branch. > > /home/pedro/gdb/mygit/src/gdb/mips-tdep.c: In function ‘ULONGEST mips_fetch_instruction(gdbarch*, mips_isa, CORE_ADDR, int*)’: > /home/pedro/gdb/mygit/src/gdb/mips-tdep.c:1460:28: error: invalid conversion from ‘int’ to ‘target_xfer_status’ [-fpermissive] > memory_error (status, addr); > > gdb/ChangeLog: > > * mips-tdep.c (mips_fetch_instruction): Add cast. > --- > gdb/mips-tdep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c > index 2275138..73b9221 100644 > --- a/gdb/mips-tdep.c > +++ b/gdb/mips-tdep.c > @@ -1456,7 +1456,7 @@ mips_fetch_instruction (struct gdbarch *gdbarch, > if (status) > { > if (statusp == NULL) > - memory_error (status, addr); > + memory_error ((enum target_xfer_status) status, addr); > return 0; > } Please don't. As discussed a while ago in IRC, I think we should stop making target_read_memory & friends return a target_xfer_status. I have a different patch in the branch to do that: https://github.com/palves/gdb/commit/22e5f84529cbe06a7b5c7fbbf662640b84e5cfb9 Thanks, Pedro Alves