From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92073 invoked by alias); 10 Oct 2015 14:52:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92057 invoked by uid 89); 10 Oct 2015 14:52:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 10 Oct 2015 14:51:59 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 5D8C98F264 for ; Sat, 10 Oct 2015 14:51:58 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9AEpuJ3018033; Sat, 10 Oct 2015 10:51:57 -0400 Message-ID: <5619260C.9060801@redhat.com> Date: Sat, 10 Oct 2015 14:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Josh Stone , gdb-patches@sourceware.org CC: sergiodj@redhat.com Subject: Re: [PATCH v2] gdb: Improve syscall entry/return tracking on Linux References: <5617FFF8.50905@redhat.com> <1444434776-4016-1-git-send-email-jistone@redhat.com> In-Reply-To: <1444434776-4016-1-git-send-email-jistone@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00123.txt.bz2 On 10/10/2015 12:52 AM, Josh Stone wrote: > 2015-10-09 Josh Stone > > * gdb.base/catch-syscall.c (unknown_syscall): New variable. > (main): Trigger a vfork and an unknown syscall. * gdb.base/catch-syscall.c: Include . (unknown_syscall): New variable. (main): Trigger a vfork and an unknown syscall. ... > int > @@ -47,6 +49,13 @@ main (void) > write (fd[1], buf1, sizeof (buf1)); > read (fd[0], buf2, sizeof (buf2)); > > + /* Test vfork-event interactions. Child exits immediately. */ > + if (vfork () == 0) > + _exit (0); Please mention that we avoid fork so the test works on no-mmu configurations. > # This procedure checks if there was a call to a syscall. > -proc check_call_to_syscall { syscall } { > +proc check_call_to_syscall { syscall { pattern "" } } { Please extend the intro comment to mention what PATTERN is for. OK with these changes. Thanks, Pedro Alves