From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10696 invoked by alias); 9 Oct 2015 12:49:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10671 invoked by uid 89); 9 Oct 2015 12:49:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 09 Oct 2015 12:49:46 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 14215C0BE09F; Fri, 9 Oct 2015 12:49:45 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t99CnhN5005241; Fri, 9 Oct 2015 08:49:43 -0400 Message-ID: <5617B7E6.1070101@redhat.com> Date: Fri, 09 Oct 2015 12:49:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Markus Metzger , dje@google.com CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/6] disas: add gdb_disassembly_vec References: <1442847283-10200-1-git-send-email-markus.t.metzger@intel.com> <1442847283-10200-4-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1442847283-10200-4-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-10/txt/msg00088.txt.bz2 On 09/21/2015 03:54 PM, Markus Metzger wrote: > Add a new function to disassemble a vector of instructions instead of a > contiguous range of instructions. The instructions can be in any order > and may originate from different functions. > > Change gdb_disassembly to create a vector of instructions from its low, > high, and how_many arguments. I wonder whether the representation could/should be based on a vector of struct mem_range's instead of a vector of instructions. I'm assuming the normal case is that we're disassembling ranges of more than one instruction. Just seems wasteful for something like (gdb) disassemble 0x3000000000,0x7000000000 to allocate so much memory. But maybe I simply misunderstood. Thanks, Pedro Alves