From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89834 invoked by alias); 30 Sep 2015 15:25:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89812 invoked by uid 89); 30 Sep 2015 15:25:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 30 Sep 2015 15:25:40 +0000 Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 71.E7.26730.D439B065; Wed, 30 Sep 2015 09:46:21 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.80) with Microsoft SMTP Server id 14.3.248.2; Wed, 30 Sep 2015 11:25:37 -0400 Subject: Re: [PATCH 3/2] Add some more casts (2/2) To: Ulrich Weigand References: <20150930151607.46D7ADC0@oc7340732750.ibm.com> CC: Yao Qi , From: Simon Marchi Message-ID: <560BFEF0.3020409@ericsson.com> Date: Wed, 30 Sep 2015 15:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150930151607.46D7ADC0@oc7340732750.ibm.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00669.txt.bz2 On 15-09-30 11:16 AM, Ulrich Weigand wrote: > Simon Marchi wrote: >> As reported by Ulrich here: >> >> https://sourceware.org/ml/gdb-patches/2015-09/msg00604.html >> >> The system compiler (gcc 4.1) in Centos 5 doesn't like that we cast to a >> pointer to a type that doesn't exist. I see no real value in using this >> kind iof construct over just using void *. So this patch changes the >> tdep_info field to void * and removes the casts. Even in C++, we >> should not need an explicit cast when assigning to a void *. >> >> gdb/ChangeLog: >> >> * gdbarch.sh (struct gdbarch_info): Change tdep_info's type to void *. >> * gdbarch.h: Regenerate. >> * i386-tdep.c (i386_gdbarch_init): Remove cast to >> struct gdbarch_tdep_info *. >> * mips-tdep.c (mips_gdbarch_init): Likewise. >> * ppc-linux-tdep (ppu2spu_sniffer): Likewise. >> * rs6000-tdep.c (rs6000_gdbarch_init): Likewise. >> * spu-multiarch.c (spu_gdbarch): Likewise. > > This is OK, thanks! > > Bye, > Ulrich > Pushed, thanks!