From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119405 invoked by alias); 30 Sep 2015 13:50:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119391 invoked by uid 89); 30 Sep 2015 13:50:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 30 Sep 2015 13:50:32 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id EB6C2C0B64C8; Wed, 30 Sep 2015 13:50:30 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8UDoTtU016189; Wed, 30 Sep 2015 09:50:30 -0400 Message-ID: <560BE8A5.40601@redhat.com> Date: Wed, 30 Sep 2015 13:50:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Andrew Burgess , gdb-patches@sourceware.org Subject: Re: [PATCH 7/9] gdb: Simplify parse_frame_specification. References: <1ab61c6dfa5023cb22691efb528c0d7078675da8.1441996064.git.andrew.burgess@embecosm.com> In-Reply-To: <1ab61c6dfa5023cb22691efb528c0d7078675da8.1441996064.git.andrew.burgess@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00662.txt.bz2 On 09/11/2015 07:49 PM, Andrew Burgess wrote: > Remove an unneeded parameter from parse_frame_specification, replace > with a fixed string within parse_frame_specification. The message was > the same in every place that parse_frame_specification was used anyway. > > gdb/ChangeLog: > > * stack.c (parse_frame_specification): Remove message parameter, > replace with fixed string in function body, update function > comment. > (frame_info): Remove message to parse_frame_specification. > (select_frame_command): Likewise. OK. Thanks, Pedro Alves