From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101790 invoked by alias); 30 Sep 2015 13:47:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101780 invoked by uid 89); 30 Sep 2015 13:47:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 30 Sep 2015 13:47:29 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 985B59158A; Wed, 30 Sep 2015 13:47:28 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8UDlQ4l013814; Wed, 30 Sep 2015 09:47:27 -0400 Message-ID: <560BE7EE.2090401@redhat.com> Date: Wed, 30 Sep 2015 13:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Andrew Burgess , gdb-patches@sourceware.org Subject: Re: [PATCH 5/9] gdb: Fix bug with dbx style func command. References: <8629fd6198d107d87d4db9b3eec45774bfaae2b6.1441996064.git.andrew.burgess@embecosm.com> In-Reply-To: <8629fd6198d107d87d4db9b3eec45774bfaae2b6.1441996064.git.andrew.burgess@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00660.txt.bz2 On 09/11/2015 07:49 PM, Andrew Burgess wrote: > The func command, available when starting gdb in dbx mode, is supposed > to take a function name and locate the frame for that function in the > stack. This has been broken for a while due to an invalid check of the > arguments within the worker function. Fixed in this commit. I wonder whether anyone uses / cares about the dbx mode... > > gdb/ChangeLog: > > * stack.c (func_command): Return early when there is no ARG > string. > > gdb/testsuite/ChangeLog: > > * gdb.base/dbx.exp (test_func): Remove xfails, update expected > results. OK. Thanks, Pedro Alves