Re: [PATCH] infcmd.c: Don't attempt to record a NULL value after a finish command

Kevin Buettner
2015-09-30T13:02:20Z

On Wed, 30 Sep 2015 13:21:34 +0100
Pedro Alves <palves@redhat.com> wrote:

> >> I assume that it's record_latest_value that crashes? Isn't the right
> >> fix instead:
> >>
> >> rv->value = get_return_value (func, rv->type);
> >> - rv->value_history_index = record_latest_value (rv->value);
> >> + if (rv->value != NULL)
> >> + rv->value_history_index = record_latest_value (rv->value);
> >>
> >
> > You're right. (I honestly don't know what I was thinking.)
> >
> > Please commit your patch instead.
>
> I don't have a patch -- I wrote that hunk by hand
> in the mail client. :-) Please fix up yours and push it.

Oh, okay.

It's pushed.

Kevin