From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104809 invoked by alias); 25 Sep 2015 11:42:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104796 invoked by uid 89); 25 Sep 2015 11:42:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 25 Sep 2015 11:42:11 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 67.D1.32596.0D3D4065; Fri, 25 Sep 2015 06:55:44 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.95) with Microsoft SMTP Server id 14.3.248.2; Fri, 25 Sep 2015 07:42:08 -0400 Subject: Re: [PATCH] Fix use of uninitialized value in linux-arm-low in GDBServer. To: Yao Qi References: <1443115845-3044-1-git-send-email-antoine.tremblay@ericsson.com> <86si6292lt.fsf@gmail.com> <5605310C.8080004@ericsson.com> CC: From: Antoine Tremblay Message-ID: <56053310.6060802@ericsson.com> Date: Fri, 25 Sep 2015 11:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <5605310C.8080004@ericsson.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00571.txt.bz2 On 09/25/2015 07:33 AM, Antoine Tremblay wrote: > > > On 09/25/2015 07:10 AM, Yao Qi wrote: >> Antoine Tremblay writes: >> >>> In arm_breakpoint_at, an uninitialized unsigned long was used were only >>> 4 bytes would be written to the variable thus polluting the value on >>> 64bit. >> >> 'unsigned long' is 32-bit on arm. What problem do you want to fix? >> > > Won't this function be used if you're debugging an arm program on aarch64 ? > Looking at it more , I don't think so, sorry for the noise it just jumped to me as I was fixing a similar issue elsewhere.