From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95612 invoked by alias); 24 Sep 2015 20:10:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95595 invoked by uid 89); 24 Sep 2015 20:10:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_40,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.openwide.fr Received: from mx1.openwide.fr (HELO mx1.openwide.fr) (213.162.52.98) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 24 Sep 2015 20:10:48 +0000 Received: from localhost (localhost [127.0.0.1]) by zimbra2.corp.accelance.fr (Postfix) with ESMTP id 2A93BC13EEBF4; Thu, 24 Sep 2015 22:10:45 +0200 (CEST) Received: from mx1.openwide.fr ([127.0.0.1]) by localhost (zimbra2.corp.accelance.fr [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id foy1e9xONrCu; Thu, 24 Sep 2015 22:10:43 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra2.corp.accelance.fr (Postfix) with ESMTP id 83687C13EEBF7; Thu, 24 Sep 2015 22:10:43 +0200 (CEST) Received: from mx1.openwide.fr ([127.0.0.1]) by localhost (zimbra2.corp.accelance.fr [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id zssLvj9uvc39; Thu, 24 Sep 2015 22:10:43 +0200 (CEST) Received: from [192.168.0.10] (gam75-1-81-57-22-125.fbx.proxad.net [81.57.22.125]) by zimbra2.corp.accelance.fr (Postfix) with ESMTPSA id CE599C13EEBF4; Thu, 24 Sep 2015 22:10:42 +0200 (CEST) Subject: Re: [PATCH] [RFC] gdb: add disable-docs option To: gdb-patches@sourceware.org References: <1441532245-23124-1-git-send-email-romain.naour@openwide.fr> Cc: Yao Qi , Thomas Petazzoni , Yao Qi From: Romain Naour Message-ID: <560458C2.8000703@openwide.fr> Date: Thu, 24 Sep 2015 20:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441532245-23124-1-git-send-email-romain.naour@openwide.fr> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00563.txt.bz2 Ping. Best regards, Romain Naour Le 06/09/2015 11:37, Romain Naour a =E9crit : > If makeinfo is not found in the system then the missing > script is used to warn the user. >=20 > Before commit e30465112ed4c6320dd19107302057a5f7712cf2 the missing > script returned 0 after printing the message. >=20 > Now, missing return 127 (command not found) to the Makefile and > the build fail. >=20 > As suggested [1], add a new option to disable the documentation. >=20 > [1] http://lists.busybox.net/pipermail/buildroot/2015-September/138824.ht= ml >=20 > Fixes: > http://autobuild.buildroot.net/results/dee/dee1326baf26ad1eb6e12a7d033428= eca50d00bc/build-end.log >=20 > Signed-off-by: Romain Naour > Cc: Yao Qi > Cc: Thomas Petazzoni > --- > This patch is untested since I can't regenerate the configure script > due to autoconf version mismatch. >=20 > configure.ac:34: error: Please use exactly Autoconf 2.64 instead of 2.69. > --- > gdb/ChangeLog | 4 ++++ > gdb/Makefile.in | 7 ++++++- > gdb/configure.ac | 7 +++++++ > 3 files changed, 17 insertions(+), 1 deletion(-) >=20 > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 370980d..900e53f 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,7 @@ > +2015-09-06 Romain Naour (tiny change) > + > + * configure.ac: add disable-docs option > + > 2015-09-04 Andrew Burgess >=20=20 > * tui/tui-data.c (win_with_focus): Remove cast of NULL pointer. > diff --git a/gdb/Makefile.in b/gdb/Makefile.in > index 0d7cf97..bfbb6be 100644 > --- a/gdb/Makefile.in > +++ b/gdb/Makefile.in > @@ -1089,7 +1089,12 @@ COMMON_OBS =3D $(DEPFILES) $(CONFIG_OBS) $(YYOBJ) \ >=20=20 > TSOBS =3D inflow.o >=20=20 > -SUBDIRS =3D doc @subdirs@ data-directory $(GNULIB_BUILDDIR) > +SUBDIRS =3D @subdirs@ data-directory $(GNULIB_BUILDDIR) > + > +if INSTALL_DOC > +SUBDIRS +=3D doc > +endif > + > CLEANDIRS =3D $(SUBDIRS) >=20=20 > # List of subdirectories in the build tree that must exist. > diff --git a/gdb/configure.ac b/gdb/configure.ac > index 29d0b63..79c370b 100644 > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -107,6 +107,13 @@ PACKAGE=3Dgdb > AC_DEFINE_UNQUOTED(PACKAGE, "$PACKAGE", [Name of this package. ]) > AC_SUBST(PACKAGE) >=20=20 > +# Enable/Disable documentation > +AC_ARG_ENABLE([docs], > + [AS_HELP_STRING([--disable-docs], > + [disable building of documentation])], > + wantdocs=3D$enableval, wantdocs=3Dyes) > +AM_CONDITIONAL([INSTALL_DOC], [test "$wantdocs" =3D "yes"]) > + > # We never need to detect it in this sub-configure. > # But preserve it for config.status --recheck. > AC_ARG_VAR(MAKEINFO, >=20