From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id U5oGKNxDP2jnyz8AWB0awg (envelope-from ) for ; Tue, 03 Jun 2025 14:50:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1748976604; bh=+UyuCDrZ6K8agrzS7oP28PdhTsvhmDGU0KshlciUCGI=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GbrI00gng2sCwcdYuAzkNDGsRWk1vyga5osIVjKUwnEoiam3heFaazBmPE6grXztA VqU1B0xqdSt36PV37OOQeBn+9jALVI81KOOW0e77HA5EhqaSf7T0z6DCY385ESrF1B QVNn5TmJMbL/OLxF4qZ4RHp+eq4aVpij5dEvAeXY= Received: by simark.ca (Postfix, from userid 112) id 8D5651E102; Tue, 3 Jun 2025 14:50:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=o42UdMmr; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=vBiebQzo; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 088BC1E0C2 for ; Tue, 3 Jun 2025 14:50:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 95B91385840E for ; Tue, 3 Jun 2025 18:50:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 95B91385840E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=o42UdMmr; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=vBiebQzo Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 14DCB3858D34 for ; Tue, 3 Jun 2025 18:49:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14DCB3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 14DCB3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748976573; cv=none; b=gOpf3WIk97yu66PUzz3jQv3m740PjTXr2sM1CJ/dwl1ac50iWagNuzdfIQkLzjMuealw16ROxUWb57bjmvYHDvPZb6lxmXkWpNqu13wPeKzeWkExYxESd4rKlU9R5hwGEWKUFGrwv0+8U5oj/CsAMbAdBG9KJmFsCxy8GMgVHqA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748976573; c=relaxed/simple; bh=+UyuCDrZ6K8agrzS7oP28PdhTsvhmDGU0KshlciUCGI=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=E1Fe+UNbC0CcswTji6Gal2HZIKKuBCYt5aodAkRpeiXjoUzlZyi4mZGiFzuFrOzAk7QXuA2+NbpuEX/VO8xTvvrq+hpIUFIW1O+nua2StGvpQ1xnYARPjx94zUu9Zw234LLIPJRdNHgUk/ke+ZFmdj9h/FYRrERINDmoah/JMKg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 14DCB3858D34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1748976572; bh=+UyuCDrZ6K8agrzS7oP28PdhTsvhmDGU0KshlciUCGI=; h=Date:Subject:To:References:From:In-Reply-To:From; b=o42UdMmrUWZBe+nY/3ZyLFI+AiPbdoFRVzJXFMu+CNiptYpglr7IxLlJYGfv1p7hH bJ+2k9vef9OhfAaWgeYUrf2blgnNp0tVP7BJHmGDxmPNsSktzkSo1XlxzPTw6O33B+ NL4lOAIqSBtd1kWB539uHoLw7Dtw2xc83xvGFgDk= Received: by simark.ca (Postfix, from userid 112) id 593BE1E102; Tue, 3 Jun 2025 14:49:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1748976563; bh=+UyuCDrZ6K8agrzS7oP28PdhTsvhmDGU0KshlciUCGI=; h=Date:Subject:To:References:From:In-Reply-To:From; b=vBiebQzoO88cnsBO2EsEB7aQqz2pMlaYdji5wrzmsco134i3SCs1ZLnI4PrlYeseb 4r6X7rJ3FGvZA0AAG7p16ymTcycO7V+x8+fVyPmDfnDyTadp96MkzwJ6VCasEGS3zt tz3yHxylFmmfUeWXmHpN7uDqEYUZHSlQBlLlVRn8= Received: from [172.16.0.192] (192-222-132-26.qc.cable.ebox.net [192.222.132.26]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 080931E0C2; Tue, 3 Jun 2025 14:49:23 -0400 (EDT) Message-ID: <55cdf445-fee8-4e70-99c0-6d42eb68cd7d@simark.ca> Date: Tue, 3 Jun 2025 14:49:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb/alpha: Add target description support To: Yodel Eldar , gdb-patches@sourceware.org References: <20250526151219.399450-1-yodel.eldar@gmail.com> <20250526151219.399450-2-yodel.eldar@gmail.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20250526151219.399450-2-yodel.eldar@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/26/25 11:12 AM, Yodel Eldar wrote: > @@ -1715,11 +1696,39 @@ alpha_software_single_step (struct regcache *regcache) > static struct gdbarch * > alpha_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) > { > + tdesc_arch_data_up tdesc_data; > + const struct target_desc *tdesc = info.target_desc; > + > /* Find a candidate among extant architectures. */ > arches = gdbarch_list_lookup_by_info (arches, &info); > if (arches != NULL) > return arches->gdbarch; > > + if (tdesc == nullptr) > + tdesc = tdesc_alpha; > + > + /* Validate target description. */ > + if (tdesc_has_registers (tdesc)) > + { > + const struct tdesc_feature *feature; > + bool valid_p; > + > + feature = tdesc_find_feature (tdesc, "org.gnu.gdb.alpha.core"); > + if (feature == nullptr) > + return nullptr; > + > + tdesc_data = tdesc_data_alloc (); > + valid_p = true; > + for (int i = 0; i < ALPHA_NUM_REGS; ++i) > + valid_p &= tdesc_numbered_register (feature, tdesc_data.get (), i, > + alpha_register_names[i]); > + > + if (!valid_p) > + return nullptr; Do we need to call tdesc_numbered_register for the register whose name is ""? I suppose that we do, for backwards compatibility, when debugging against a remote target that doesn't send a target description? Simon