From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40110 invoked by alias); 18 Sep 2015 12:56:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40101 invoked by uid 89); 18 Sep 2015 12:56:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 18 Sep 2015 12:56:41 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id CF0792F02DC; Fri, 18 Sep 2015 12:56:40 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8ICudXr004535; Fri, 18 Sep 2015 08:56:40 -0400 Message-ID: <55FC0A07.1090208@redhat.com> Date: Fri, 18 Sep 2015 12:56:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Metzger, Markus T" CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] btrace, testsuite: fix spurious gdb.btrace/tsx.exp fails References: <1442565363-13628-1-git-send-email-markus.t.metzger@intel.com> <55FBF91C.8070703@redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00468.txt.bz2 On 09/18/2015 01:12 PM, Metzger, Markus T wrote: >> -----Original Message----- >> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- >> owner@sourceware.org] On Behalf Of Pedro Alves >> Sent: Friday, September 18, 2015 1:44 PM >> To: Metzger, Markus T >> Cc: gdb-patches@sourceware.org >> Subject: Re: [PATCH] btrace, testsuite: fix spurious gdb.btrace/tsx.exp fails >> >> On 09/18/2015 09:36 AM, Markus Metzger wrote: >>> If the atomic section in x86-tsx.S is aborted, >> >> When can that happen? Is it normal that the test sees this? > > A transaction can be aborted for various reasons. One such reason is an > interrupt, which can happen at any time. I was under the impression that the hardware or kernel would retry the transaction and that that would be transparent to userspace, but sounds like not then. > This occurs very infrequently. After I saw this the first time, I had to re-run > the test several dozen times to reproduce it again. +gdb_test_multiple "record instruction-history" "speculation indication" { + -re "$abort_1.*$gdb_prompt $" { + pass "speculation indication: abort" + } + -re "$abort_2.*$gdb_prompt $" { + pass "speculation indication: abort" + } + -re "$begin_to_end.*$gdb_prompt $" { + pass "speculation indication: begin..end" + } +} Note this will cause ping-ponging of PASS messages, resulting in spurious changes in test result diffing. I'd suggest using the same message in all cases. Thanks, Pedro Alves