From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-126202-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 78332 invoked by alias); 18 Sep 2015 11:39:53 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 78321 invoked by uid 89); 18 Sep 2015 11:39:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 18 Sep 2015 11:39:51 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (Postfix) with ESMTPS id 87790AC1A1;	Fri, 18 Sep 2015 11:39:50 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8IBdmYg032529;	Fri, 18 Sep 2015 07:39:49 -0400
Message-ID: <55FBF804.2050304@redhat.com>
Date: Fri, 18 Sep 2015 11:39:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Markus Metzger <markus.t.metzger@intel.com>
CC: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 19/19] btrace: honour scheduler-locking for all-stop targets
References: <1442498990-1222-1-git-send-email-markus.t.metzger@intel.com> <1442498990-1222-20-git-send-email-markus.t.metzger@intel.com>
In-Reply-To: <1442498990-1222-20-git-send-email-markus.t.metzger@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-09/txt/msg00442.txt.bz2

On 09/17/2015 03:09 PM, Markus Metzger wrote:
> +foreach schedlock { "replay" "on" } {
> +	with_test_prefix "schedlock-$schedlock" {
> +		gdb_test_no_output "set scheduler-locking $schedlock"
> +
> +		test_navigate
> +		test_step
> +		test_cont
> +		test_rstep
> +		test_goto_end
> +	}
>  }
>  

Indenting here looks odd compared to the rest of the file.

I'd merge in the "step" case too, like:

foreach schedlock { "replay" "on" "step" } {
    with_test_prefix "schedlock-$schedlock" {
	gdb_test_no_output "set scheduler-locking $schedlock"

	test_navigate
	test_step
	if {$schedlock == "step"} {
	    test_cont_all
	} else {
	    test_cont
	}
	test_rstep
	test_goto_end
    }
}

Otherwise looks fine to me.

Thanks,
Pedro Alves