From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106729 invoked by alias); 17 Sep 2015 05:17:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106719 invoked by uid 89); 17 Sep 2015 05:17:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Sep 2015 05:17:27 +0000 Received: from svr-orw-fem-02x.mgc.mentorg.com ([147.34.96.206] helo=SVR-ORW-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZcRZU-0002u4-0d from Sandra_Loosemore@mentor.com ; Wed, 16 Sep 2015 22:17:24 -0700 Received: from [IPv6:::1] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.3.224.2; Wed, 16 Sep 2015 22:17:23 -0700 Message-ID: <55FA4CB5.4010802@codesourcery.com> Date: Thu, 17 Sep 2015 05:17:00 -0000 From: Sandra Loosemore User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Eli Zaretskii CC: Subject: Re: [patch, testsuite] check for UTF-32 target wide charset support in gdb.base/wchar.exp References: <55FA325D.1020207@codesourcery.com> <8361397hwd.fsf@gnu.org> In-Reply-To: <8361397hwd.fsf@gnu.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00396.txt.bz2 On 09/16/2015 11:07 PM, Eli Zaretskii wrote: >> Date: Wed, 16 Sep 2015 21:24:13 -0600 >> From: Sandra Loosemore >> >> If GDB is configured without ICONV support, the target wide charset >> defaults to "ISO-8859-1" (which isn't even a wide charset), and all the >> wide strings in this test print as gibberish. Otherwise, GDB seems to >> think the default is "auto; currently UTF-32", so let's make the >> dependency on UTF-32 explicit here and bail out if it's not available. > > Why UTF-32, hard-coded? Why not allow also UTF-16, for example? It looked to me like the default target wide charset is UTF-32 if you don't pick one explicitly. Since the test as currently written doesn't, the patterns the .exp file is trying to match must assume the default target wide charset, and not some other wide charset that might happen to be supported. If I'm confused and the default charset might not always be UTF-32 if ICONV is present, how about changing the testcase to bail if it sees the default wide charset is ISO-8859-1? That means either ICONV is not present or GDB's default is otherwise wrongly configured. -Sandra