Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sandra Loosemore <sandra@codesourcery.com>
To: gdb-patches <gdb-patches@sourceware.org>
Subject: [patch, testsuite] check for UTF-32 target wide charset support in gdb.base/wchar.exp
Date: Thu, 17 Sep 2015 03:25:00 -0000	[thread overview]
Message-ID: <55FA325D.1020207@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

This patch is related to the one I posted yesterday to make 
with_target_charset do something reasonable in the absence of ICONV support:

https://sourceware.org/ml/gdb-patches/2015-09/msg00357.html

If GDB is configured without ICONV support, the target wide charset 
defaults to "ISO-8859-1" (which isn't even a wide charset), and all the 
wide strings in this test print as gibberish.  Otherwise, GDB seems to 
think the default is "auto; currently UTF-32", so let's make the 
dependency on UTF-32 explicit here and bail out if it's not available.

OK to commit?

-Sandra


[-- Attachment #2: wchar.log --]
[-- Type: text/x-log, Size: 167 bytes --]

2015-09-16  Sandra Loosemore  <sandra@codesourcery.com>

	gdb/testsuite/
	* gdb.base/wchar.exp: Require UTF-32 target wide charset support,
	otherwise skip this test.

[-- Attachment #3: wchar.patch --]
[-- Type: text/x-patch, Size: 726 bytes --]

diff --git a/gdb/testsuite/gdb.base/wchar.exp b/gdb/testsuite/gdb.base/wchar.exp
index 1a5a2d4..171385b 100644
--- a/gdb/testsuite/gdb.base/wchar.exp
+++ b/gdb/testsuite/gdb.base/wchar.exp
@@ -24,6 +24,19 @@ if ![runto "wchar.c:$bp_location" ] then {
   return -1
 }
 
+# This test requires wide character support in GDB.
+# Setting the charset may fail if GDB was configured without
+# ICONV support.
+gdb_test_multiple "set target-wide-charset UTF-32" "" {
+    -re "Undefined item.*$gdb_prompt " {
+	unsupported "Unknown charset UTF-32"
+	return -1
+    }
+    -re ".*$gdb_prompt " {
+	pass "set target-wide-charset UTF-32"
+    }
+}
+
 gdb_test "print narrow" "= 97 L'a'"
 
 gdb_test "print single" "= 48879 L'\\\\xbeef'"

             reply	other threads:[~2015-09-17  3:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  3:25 Sandra Loosemore [this message]
2015-09-17  4:31 ` Doug Evans
2015-09-17  5:10   ` Eli Zaretskii
2015-09-18  4:38     ` Doug Evans
2015-09-17  5:07 ` Eli Zaretskii
2015-09-17  5:17   ` Sandra Loosemore
2015-09-17  5:59     ` Eli Zaretskii
2015-09-18  4:48     ` Doug Evans
2015-09-29 13:50       ` Pedro Alves
2015-09-18  4:41   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55FA325D.1020207@codesourcery.com \
    --to=sandra@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox