From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-126133-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18781 invoked by alias); 16 Sep 2015 13:23:54 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 18770 invoked by uid 89); 16 Sep 2015 13:23:54 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 16 Sep 2015 13:23:53 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (Postfix) with ESMTPS id 3D0F8A19B5;	Wed, 16 Sep 2015 13:23:52 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8GDNoZx002410;	Wed, 16 Sep 2015 09:23:50 -0400
Message-ID: <55F96D65.1040304@redhat.com>
Date: Wed, 16 Sep 2015 13:23:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: "Metzger, Markus T" <markus.t.metzger@intel.com>,        Jan Kratochvil <jan.kratochvil@redhat.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 17/17] infrun: scheduler-locking reverse
References: <1441794909-32718-1-git-send-email-markus.t.metzger@intel.com> <1441794909-32718-18-git-send-email-markus.t.metzger@intel.com> <55F03A12.80307@redhat.com> <20150912194344.GA7575@host1.jankratochvil.net> <A78C989F6D9628469189715575E55B23331AE05D@IRSMSX104.ger.corp.intel.com> <20150915171931.GA2056@host1.jankratochvil.net> <A78C989F6D9628469189715575E55B23331AE557@IRSMSX104.ger.corp.intel.com> <A78C989F6D9628469189715575E55B23331AE894@IRSMSX104.ger.corp.intel.com>
In-Reply-To: <A78C989F6D9628469189715575E55B23331AE894@IRSMSX104.ger.corp.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-09/txt/msg00373.txt.bz2

On 09/16/2015 01:44 PM, Metzger, Markus T wrote:

> +     For all-stop targets, we only step INFERIOR_PTID and continue others.  */
> +  if (!target_is_non_stop_p () && ptid_match (inferior_ptid, ptid))
> +    {

I'd remove that ptid_match.

> +with_test_prefix "schedlock-reverse" {
> +    gdb_test_no_output "set scheduler-locking reverse"
> +
> +    test_navigate
> +    test_step
> +    test_cont
> +    test_rstep
> +    test_goto_end
> +}
> +
> +with_test_prefix "schedlock-on" {
> +    gdb_test_no_output "set scheduler-locking on"
> +
> +    test_navigate
> +    test_step
> +    test_cont
> +    test_rstep
> +    test_goto_end
> +}
> +
> +with_test_prefix "schedlock-step" {
> +    gdb_test_no_output "set scheduler-locking step"
> +
> +    test_navigate
> +    test_step
> +    test_cont_all
> +    test_rstep
> +    test_goto_end
> +}

You can fold all these using foreach.  E.g.,

foreach schedlock {"reverse" "on" "step"} {
  with_test_prefix "schedlock-$schedlock" {
    gdb_test_no_output "set scheduler-locking $schedlock"

    test_navigate
    test_step
    test_cont_all
    test_rstep
    test_goto_end
  }
}

Otherwise LGTM.

Thanks,
Pedro Alves