From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98213 invoked by alias); 15 Sep 2015 18:35:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98202 invoked by uid 89); 15 Sep 2015 18:35:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Sep 2015 18:35:30 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 65B3F461D9; Tue, 15 Sep 2015 18:35:29 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8FIZRQ7027899; Tue, 15 Sep 2015 14:35:28 -0400 Message-ID: <55F864EF.3020708@redhat.com> Date: Tue, 15 Sep 2015 18:35:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org, donb@codesourcery.com Subject: Re: [PATCH+7.10.1] PR remote/18965: vforkdone stop reply should indicate parent PID References: <55F84540.5030901@redhat.com> <83wpvr7ikb.fsf@gnu.org> In-Reply-To: <83wpvr7ikb.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00354.txt.bz2 On 09/15/2015 05:28 PM, Eli Zaretskii wrote: >> Date: Tue, 15 Sep 2015 17:20:16 +0100 >> From: Pedro Alves >> CC: GDB Patches , >> "Breazeal, Don" >> >> Hi Eli, >> >> Are the doc bits OK? > > Yes, thanks. Thanks Eli. However, I realized the docs change was plain wrong. I've reverted it now, with the patch below. Sorry about that. Thanks, Pedro Alves >From e68fa6f07666ec4726cfef59f641a81244cc2e00 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Tue, 15 Sep 2015 19:29:37 +0100 Subject: [PATCH] gdb/doc: revert previous vforkdone change The previous manual change was wrong. The vfork parent thread ID should be reported with the usual "thread" magic register: Sending packet: $vCont;c:p7260.7260#1e...Packet received: OK - Notification received: Stop:T05vforkdone:; + Notification received: Stop:T05vforkdone:;thread:p7260.7260 ^^^^^^^^^^^^^^^^^ This is already how the parent is reported in the vfork/fork events, and is actually what the fix made gdbserver do. Following the documentation change, the event would have been reported like this instead: Notification received: Stop:T05vforkdone:p7260.7260 gdb/doc/ChangeLog: 2015-09-15 Pedro Alves PR remote/18965 * gdb.texinfo (Stop Reply Packets): Revert previous change to the vforkdone description. --- gdb/doc/ChangeLog | 6 ++++++ gdb/doc/gdb.texinfo | 11 +++++------ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 2cc6039..1e16e92 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,6 +1,12 @@ 2015-09-15 Pedro Alves PR remote/18965 + * gdb.texinfo (Stop Reply Packets): Revert previous change to + the vforkdone description. + +2015-09-15 Pedro Alves + + PR remote/18965 * gdb.texinfo (Stop Reply Packets): Explain that vforkdone's 'r' part indicates the thread ID of the parent process. diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index e80e695..4ecdb8f 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -35498,12 +35498,11 @@ indicating support. @cindex vforkdone events, remote reply @item vforkdone -The packet indicates that a child process created by a vfork has -either called @code{exec} or terminated, so that the address spaces of -the parent and child process are no longer shared. The @var{r} part -is the thread ID of the parent process. Refer to @ref{thread-id -syntax} for the format of the @var{thread-id} field. This packet is -only applicable to targets that support vforkdone events. +The packet indicates that a child process created by a vfork +has either called @code{exec} or terminated, so that the +address spaces of the parent and child process are no longer +shared. The @var{r} part is ignored. This packet is only +applicable to targets that support vforkdone events. This packet should not be sent by default; older @value{GDBN} versions did not support it. @value{GDBN} requests it, by supplying an -- 1.9.3