From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97740 invoked by alias); 15 Sep 2015 16:49:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97728 invoked by uid 89); 15 Sep 2015 16:49:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 15 Sep 2015 16:49:22 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id A1.1D.32596.15DE7F55; Tue, 15 Sep 2015 12:05:05 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.86) with Microsoft SMTP Server id 14.3.248.2; Tue, 15 Sep 2015 12:49:20 -0400 Subject: Re: [PATCH 5/7] Add support for software single step on ARM aarch32-linux in GDBServer. To: Yao Qi References: <1441973603-15247-1-git-send-email-antoine.tremblay@ericsson.com> <1441973603-15247-6-git-send-email-antoine.tremblay@ericsson.com> <8637yh5kpz.fsf@gmail.com> <55F6C071.1040104@ericsson.com> <86twqx3rty.fsf@gmail.com> <55F703AF.5010707@ericsson.com> <86pp1k406c.fsf@gmail.com> <55F8101F.1000602@ericsson.com> CC: From: Antoine Tremblay Message-ID: <55F84C0F.9010603@ericsson.com> Date: Tue, 15 Sep 2015 16:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55F8101F.1000602@ericsson.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00347.txt.bz2 On 09/15/2015 08:33 AM, Antoine Tremblay wrote: > >> From reviewer's point of view, I'd like each patch series is >> self-contained and independent. Your patch series is about supporting >> software breakpoint, software single step and tracepoint in ARM linux >> GDBserver. Why do we need to worry about the different endianness of >> GDBserver and inferior in your patch series? Your code may be right, >> and we may need them sooner or later, but we can't do all of them in one >> go. >> > > Alright, here's what I propose in this case, since we may need this > support at one point but we do not now. > > I could keep the shared breakpoints definitions , shared operation > signatures and other context that carries the endianness. > > (Note that most of this context/signatures just can't go away since it > GDB needs it and the code is shared. ) > > But I will remove the BE8 detection and ELF endianness detection from > GDBServer. > > So this way while the architecture of GDBServer will be able to handle > it from the start the feature itself won't be until a separate patch. > > Does that sound ok ? Just FYI after more thought I've decided to remove the shared breakpoints too so the only thing about endianness that will be there is what is needed to keep the get_next_pcs operations working with GDB. I'll post a "v2" with only software breakpoints & software single step soon. It should address your comments properly. Thanks for the review :)