From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34566 invoked by alias); 15 Sep 2015 16:12:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34556 invoked by uid 89); 15 Sep 2015 16:12:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Sep 2015 16:12:17 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1Zbsq6-0006Pp-96 from Don_Breazeal@mentor.com ; Tue, 15 Sep 2015 09:12:14 -0700 Received: from [172.30.14.241] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 15 Sep 2015 09:12:13 -0700 Subject: Re: [pushed][PATCH v3 1/4] Extended-remote follow exec To: Yao Qi References: <1441996698-12694-1-git-send-email-donb@codesourcery.com> <86lhc83vtp.fsf@gmail.com> CC: "gdb-patches@sourceware.org" From: Don Breazeal Message-ID: <55F84358.9030509@codesourcery.com> Date: Tue, 15 Sep 2015 16:12:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <86lhc83vtp.fsf@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00340.txt.bz2 On 9/15/2015 1:56 AM, Yao Qi wrote: > Don Breazeal writes: > > Hi Don, > I happen to read the code you pushed in some days ago... > >> @@ -2111,6 +2112,12 @@ handle_query (char *own_buf, int packet_len, int *new_packet_len_p) >> if (target_supports_vfork_events ()) >> report_vfork_events = 1; >> } >> + if (strcmp (p, "exec-events+") == 0) > > Shouldn't we use "else if"? Hi Yao, Yes, definitely "else if". Fortunately this didn't break anything. Do you want to go ahead and push the fix, or shall I do it? thanks --Don > >> + { >> + /* GDB supports and wants exec events if possible. */ >> + if (target_supports_exec_events ()) >> + report_exec_events = 1; >> + } >> else >> target_process_qsupported (p); >