From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99013 invoked by alias); 15 Sep 2015 15:53:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99003 invoked by uid 89); 15 Sep 2015 15:53:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Sep 2015 15:53:09 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1ZbsXa-00012a-Fj from Don_Breazeal@mentor.com ; Tue, 15 Sep 2015 08:53:06 -0700 Received: from [172.30.14.241] (147.34.91.1) by svr-orw-fem-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 15 Sep 2015 08:53:06 -0700 Subject: Re: [pushed][PATCH v3 3/4] Extended-remote exec test To: Pedro Alves , "Breazeal, Don" , "gdb-patches@sourceware.org" References: <1441996698-12694-1-git-send-email-donb@codesourcery.com> <1441996698-12694-3-git-send-email-donb@codesourcery.com> <55F83D18.709@redhat.com> From: Don Breazeal Message-ID: <55F83EE1.5080903@codesourcery.com> Date: Tue, 15 Sep 2015 15:53:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55F83D18.709@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00336.txt.bz2 On 9/15/2015 8:45 AM, Pedro Alves wrote: > Hi Don, > > On 09/11/2015 07:38 PM, Don Breazeal wrote: >> gdb_breakpoint [gdb_get_line_number "break-here"] >> - gdb_continue_to_breakpoint "break-here" ".* break-here .*" >> + gdb_test_multiple "continue" "continue to breakpoint" { >> + -re ".*Breakpoint.*break-here.*" { >> + pass "continue to breakpoint" >> + } >> + } >> > > This change is causing a regression. Was there a reason for it? > AFAICS, none of the other non-ldr-exc-*.exp files got this change. No, I intended to revert that change, which I did for the other non-ldr-exc-* files. You had pointed out that the change introduced a race. > > Fix below. > > From 5cd484be64e40d0423cc7fe8d8355421e4da1fff Mon Sep 17 00:00:00 2001 > From: Pedro Alves > Date: Tue, 15 Sep 2015 16:32:19 +0100 > Subject: [PATCH] Fix gdb.threads/non-ldr-exc-3.exp race > > gdb.threads/non-ldr-exc-3.exp is sometimes failing like this: > > [Switching to Thread 6831.6832] > > Breakpoint 2, thread_execler (arg=0x0) at /home/pedro/gdb/mygit/build/../src/gdb/testsuite/gdb.threads/non-ldr-exc-3.c:41 > 41 if (execl (image, image, argv1, NULL) == -1) /* break-here */ > PASS: gdb.threads/non-ldr-exc-3.exp: lock-sched=on,non-stop=off: continue to breakpoint > (gdb) set scheduler-locking on > (gdb) FAIL: gdb.threads/non-ldr-exc-3.exp: lock-sched=on,non-stop=off: set scheduler-locking on > > The problem is that the gdb_test_multiple is missing the prompt > anchor. The problem was introduced by 2fd33e9448. This reverts the > hunk that introduced the problem, reverting back to > gdb_continue_to_breakpoint. > > gdb/testsuite/ChangeLog: > 2015-09-15 Pedro Alves > > * gdb.threads/non-ldr-exc-3.exp (do_test): Use > gdb_continue_to_breakpoint instead of gdb_test_multiple. > --- > gdb/testsuite/gdb.threads/non-ldr-exc-3.exp | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/gdb/testsuite/gdb.threads/non-ldr-exc-3.exp b/gdb/testsuite/gdb.threads/non-ldr-exc-3.exp > index 3e7a3a1..188b825 100644 > --- a/gdb/testsuite/gdb.threads/non-ldr-exc-3.exp > +++ b/gdb/testsuite/gdb.threads/non-ldr-exc-3.exp > @@ -45,11 +45,7 @@ proc do_test { lock_sched nonstop } { > } > > gdb_breakpoint [gdb_get_line_number "break-here"] > - gdb_test_multiple "continue" "continue to breakpoint" { > - -re ".*Breakpoint.*break-here.*" { > - pass "continue to breakpoint" > - } > - } > + gdb_continue_to_breakpoint "break-here" ".* break-here .*" > > # Also test with sched-lock to make sure we can follow the > # non-leader thread execing even though the main thread wasn't >