From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36609 invoked by alias); 15 Sep 2015 15:45:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36599 invoked by uid 89); 15 Sep 2015 15:45:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Sep 2015 15:45:31 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id A31372ED154; Tue, 15 Sep 2015 15:45:30 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8FFjT6f021227; Tue, 15 Sep 2015 11:45:29 -0400 Message-ID: <55F83D18.709@redhat.com> Date: Tue, 15 Sep 2015 15:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Don Breazeal , gdb-patches@sourceware.org Subject: Re: [pushed][PATCH v3 3/4] Extended-remote exec test References: <1441996698-12694-1-git-send-email-donb@codesourcery.com> <1441996698-12694-3-git-send-email-donb@codesourcery.com> In-Reply-To: <1441996698-12694-3-git-send-email-donb@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00335.txt.bz2 Hi Don, On 09/11/2015 07:38 PM, Don Breazeal wrote: > gdb_breakpoint [gdb_get_line_number "break-here"] > - gdb_continue_to_breakpoint "break-here" ".* break-here .*" > + gdb_test_multiple "continue" "continue to breakpoint" { > + -re ".*Breakpoint.*break-here.*" { > + pass "continue to breakpoint" > + } > + } > This change is causing a regression. Was there a reason for it? AFAICS, none of the other non-ldr-exc-*.exp files got this change. Fix below. >From 5cd484be64e40d0423cc7fe8d8355421e4da1fff Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Tue, 15 Sep 2015 16:32:19 +0100 Subject: [PATCH] Fix gdb.threads/non-ldr-exc-3.exp race gdb.threads/non-ldr-exc-3.exp is sometimes failing like this: [Switching to Thread 6831.6832] Breakpoint 2, thread_execler (arg=0x0) at /home/pedro/gdb/mygit/build/../src/gdb/testsuite/gdb.threads/non-ldr-exc-3.c:41 41 if (execl (image, image, argv1, NULL) == -1) /* break-here */ PASS: gdb.threads/non-ldr-exc-3.exp: lock-sched=on,non-stop=off: continue to breakpoint (gdb) set scheduler-locking on (gdb) FAIL: gdb.threads/non-ldr-exc-3.exp: lock-sched=on,non-stop=off: set scheduler-locking on The problem is that the gdb_test_multiple is missing the prompt anchor. The problem was introduced by 2fd33e9448. This reverts the hunk that introduced the problem, reverting back to gdb_continue_to_breakpoint. gdb/testsuite/ChangeLog: 2015-09-15 Pedro Alves * gdb.threads/non-ldr-exc-3.exp (do_test): Use gdb_continue_to_breakpoint instead of gdb_test_multiple. --- gdb/testsuite/gdb.threads/non-ldr-exc-3.exp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/gdb/testsuite/gdb.threads/non-ldr-exc-3.exp b/gdb/testsuite/gdb.threads/non-ldr-exc-3.exp index 3e7a3a1..188b825 100644 --- a/gdb/testsuite/gdb.threads/non-ldr-exc-3.exp +++ b/gdb/testsuite/gdb.threads/non-ldr-exc-3.exp @@ -45,11 +45,7 @@ proc do_test { lock_sched nonstop } { } gdb_breakpoint [gdb_get_line_number "break-here"] - gdb_test_multiple "continue" "continue to breakpoint" { - -re ".*Breakpoint.*break-here.*" { - pass "continue to breakpoint" - } - } + gdb_continue_to_breakpoint "break-here" ".* break-here .*" # Also test with sched-lock to make sure we can follow the # non-leader thread execing even though the main thread wasn't -- 1.9.3