Re: [obv] [testsuite] i386-biarch-core.exp: Fix comment typo

Luis Machado
2015-09-15T14:03:37Z

On 07/14/2015 02:51 PM, Jan Kratochvil wrote:
>
> ForwardedMessage.eml
>
> Subject:
> [PATCH] i386-biarch-core.exp: Fix comment typo
> From:
> Jan Kratochvil <jan.kratochvil@redhat.com>
> Date:
> 07/14/2015 02:50 PM
>
>
> gdb/testsuite/ChangeLog
> 2015-07-14 Jan Kratochvil<jan.kratochvil@redhat.com>
>
> * gdb.arch/i386-biarch-core.exp: Fix comment typo.
> ---
> gdb/testsuite/ChangeLog | 4 ++++
> gdb/testsuite/gdb.arch/i386-biarch-core.exp | 2 +-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index 47c1e9b..5e8b930 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,3 +1,7 @@
> +2015-07-14 Jan Kratochvil<jan.kratochvil@redhat.com>
> +
> + * gdb.arch/i386-biarch-core.exp: Fix comment typo.
> +
> 2015-07-14 Pedro Alves<palves@redhat.com>
>
> * gdb.base/killed-outside.exp: New file.
> diff --git a/gdb/testsuite/gdb.arch/i386-biarch-core.exp b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
> index 612b4d8..60d049b 100644
> --- a/gdb/testsuite/gdb.arch/i386-biarch-core.exp
> +++ b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
> @@ -50,7 +50,7 @@ gdb_reinitialize_dir $srcdir/$subdir
> # Wrongly built GDB complains by:
> # "..." is not a core dump: File format not recognized
> # As the provided test core has 64bit PRSTATUS i386 built GDB cannot parse it.
> -# This is just a problem of the test care, real-world elf64-i386 file will have
> +# This is just a problem of the test case, real-world elf64-i386 file will have
> # 32bit PRSTATUS. One cannot prepare elf64-i386 core file from elf32-i386 by
> # objcopy as it corrupts the core file beyond all recognition.
> gdb_test "core-file ${corefile}" "\r\nwarning: Unexpected size of section `\\.reg/6901' in core file\\.\r\n.*Core was generated by `\[^\r\n\]*'\\.\r\nProgram terminated with signal SIGSEGV, Segmentation fault\\.\r\n.*" "core-file"
> -- 2.1.0
>

I noticed this test is running for MIPS (and probably other non-i386
targets). Was it really your intention to have this test execute on
non-i386 targets?