From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61088 invoked by alias); 14 Sep 2015 17:28:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61078 invoked by uid 89); 14 Sep 2015 17:28:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 14 Sep 2015 17:28:18 +0000 Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 68.9A.32596.EF4A6F55; Mon, 14 Sep 2015 12:44:14 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.89) with Microsoft SMTP Server id 14.3.248.2; Mon, 14 Sep 2015 13:28:15 -0400 Subject: Re: [PATCH 5/7] Add support for software single step on ARM aarch32-linux in GDBServer. To: Yao Qi References: <1441973603-15247-1-git-send-email-antoine.tremblay@ericsson.com> <1441973603-15247-6-git-send-email-antoine.tremblay@ericsson.com> <8637yh5kpz.fsf@gmail.com> <55F6C071.1040104@ericsson.com> <86twqx3rty.fsf@gmail.com> CC: From: Antoine Tremblay Message-ID: <55F703AF.5010707@ericsson.com> Date: Mon, 14 Sep 2015 17:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <86twqx3rty.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00301.txt.bz2 On 09/14/2015 12:10 PM, Yao Qi wrote: > Antoine Tremblay writes: > >> Usually it will be , however see commit : >> dcd4a3a4e7fc3912194d1346d2dfc6252f70b456 >> >> Which I will partially quote here : >> >> "tdep->arm_breakpoint, tdep->thumb_breakpoint, tdep->thumb2_breakpoint >> should be set le_ variants in case of arm BE8 code. Those instruciton >> sequences are writen to target with simple write_memory, without >> regarding gdbarch_byte_order_for_code. But in BE8 case even data >> memory is in big endian form, instructions are still in little endian >> form." >> >> So in BE8 code the instructions are not of the same endianness as the >> data memory... > > Do you want to support BE8 in GDBserver in your patches? If yes, please > split them out of your patch set. Current GDBserver doesn't consider > the difference of data endianness and instruction endianness, so you > don't have to worry about it too much, unless you really want to fix > problems on this. > Well my goal is to have feature parity between GDB and GDBServer as much as possible, so yes I would like to support BE8 in GDBServer. Since BE8 support entails endianness awareness I can't split them out logically based on the BE8 feature, that would be writing the breakpoint handling code code without endianness support and then rewriting it completely with a patch labeled BE8 that would teach endianness to these features. This would be a major overhead with no value imho. Maybe I misunderstood what you meant ? I think it's better to include endianness awareness in GDBServer from patch1 and not redo the work. In that case BE8 support becomes only 1 variable in a function and thus does not need it's own patch. >> >> Also even if unlikely you could have a BE program being debugged in a >> LE GDBServer assuming the proper BE libs are also present on the >> system. > > I don't think it is practical to do so... > Me neither but I would say it's a matter of context and that if supporting it is easy and needed by another feature anyway, why not ?