Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] btrace, test: remove buffer-size test with unlimited buffer size
Date: Fri, 11 Sep 2015 09:30:00 -0000	[thread overview]
Message-ID: <55F29F2A.9050709@redhat.com> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B23331AD33B@IRSMSX104.ger.corp.intel.com>

On 09/11/2015 10:18 AM, Metzger, Markus T wrote:
>> -----Original Message-----
>> From: Pedro Alves [mailto:palves@redhat.com]
>> Sent: Friday, September 11, 2015 11:15 AM
>> To: Metzger, Markus T
>> Cc: gdb-patches@sourceware.org
>> Subject: Re: [PATCH] btrace, test: remove buffer-size test with unlimited
>> buffer size
>>
>> On 09/11/2015 10:02 AM, Markus Metzger wrote:
>>> The gdb.btrace/buffer-size.exp test starts recording with an unlimited
>>> buffer size.  This will, for a short time, use up most if not all BTS
>>> resources.
>>>
>>> I don' think this test is necessary.  Remove it.
>>>
>>
>> Fine with me.
>>
>> Note you don't really need approval to push this in.
> 
> Nice.  But we still want patches to be reviewed, don't we?

Certainly.  And I'll gladly review anything you send my way.

> Or does this fall under the obvious rule?

I wouldn't say the idea is obvious, though once the idea
is accepted, the code changes are indeed obvious.

Thanks,
Pedro Alves


      reply	other threads:[~2015-09-11  9:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11  9:02 Markus Metzger
2015-09-11  9:15 ` Pedro Alves
2015-09-11  9:18   ` Metzger, Markus T
2015-09-11  9:30     ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F29F2A.9050709@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox