From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-125930-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 97334 invoked by alias); 10 Sep 2015 14:34:41 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 96685 invoked by uid 89); 10 Sep 2015 14:34:41 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Sep 2015 14:34:35 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (Postfix) with ESMTPS id 60F4EC0B2B5C;	Thu, 10 Sep 2015 14:34:34 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8AEYWQb009428;	Thu, 10 Sep 2015 10:34:33 -0400
Message-ID: <55F194F8.3090805@redhat.com>
Date: Thu, 10 Sep 2015 14:34:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>,        Yao Qi <qiyaoltc@gmail.com>
CC: gdb-patches@sourceware.org
Subject: Re: [PATCH V2] PR varobj/18564  regression in showing __thread so extern variable
References: <1440934487.22248.9.camel@skynet.be> <86wpw9x9au.fsf@gmail.com>	 <1441229015.13071.23.camel@skynet.be> <86h9nbyhb6.fsf@gmail.com> <1441317832.4429.4.camel@skynet.be>
In-Reply-To: <1441317832.4429.4.camel@skynet.be>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-09/txt/msg00170.txt.bz2

On 09/03/2015 11:03 PM, Philippe Waroquiers wrote:
> On Thu, 2015-09-03 at 10:37 +0100, Yao Qi wrote:
>> We don't have to get printf involved in the test, because some targets
>> may don't have printf at all.
> Ok, effectively, without printf, the test will then run on these
> targets.
> 
> Find below the new version of the patch.
> All your comments should be handled.
> 
> The fix itself still need to be reviewed.
> 
> Thanks for your review
> 
> Any comment on the fix ? Ok to commit ?

This is OK.  Thanks for fixing this.

Thanks,
Pedro Alves