From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72976 invoked by alias); 10 Sep 2015 13:26:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72299 invoked by uid 89); 10 Sep 2015 13:26:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Sep 2015 13:26:10 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id D54DC461ED; Thu, 10 Sep 2015 13:26:08 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8ADQ7ci024752; Thu, 10 Sep 2015 09:26:07 -0400 Message-ID: <55F184EE.8010903@redhat.com> Date: Thu, 10 Sep 2015 13:26:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Don Breazeal , gdb-patches@sourceware.org Subject: Re: [PATCH v3 3/4] Extended-remote support for exec event tests References: <1438298360-29594-1-git-send-email-donb@codesourcery.com> <1441839937-22251-1-git-send-email-donb@codesourcery.com> <1441839937-22251-4-git-send-email-donb@codesourcery.com> In-Reply-To: <1441839937-22251-4-git-send-email-donb@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00164.txt.bz2 Hi Don, This is OK. One nit below. On 09/10/2015 12:05 AM, Don Breazeal wrote: >> Note that schedlock on has no effect in non-stop mode. >> Maybe if !lock_sched && nonstop, we could issue "continue -a" >> instead of continue. > > I couldn't find any documentation of 'continue -a'. (?) I just used > a conditional to prevent running the lock_sched/nonstop tests. I see that the "Continuing and Stepping" section doesn't mention it. It's mentioned in "help continue", and here in the manual: In non-stop mode, all execution commands apply only to the current thread by default. That is, @code{continue} only continues one thread. To continue all threads, issue @code{continue -a} or @code{c -a}. > diff --git a/gdb/testsuite/gdb.threads/non-ldr-exc-1.exp b/gdb/testsuite/gdb.threads/non-ldr-exc-1.exp > index 69e5cc6..3e5c902 100644 > --- a/gdb/testsuite/gdb.threads/non-ldr-exc-1.exp > +++ b/gdb/testsuite/gdb.threads/non-ldr-exc-1.exp > @@ -28,11 +28,14 @@ if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executab > return -1 > } > > -proc do_test { lock_sched } { > - with_test_prefix "lock-sched$lock_sched" { > +proc do_test { lock_sched nonstop } { > + with_test_prefix "lock-sched$lock_sched,non-stop$nonstop" { AFAICS, this will render as: lock-schedoff,non-stopon etc. I suggest adding a '=': with_test_prefix "lock-sched=$lock_sched,non-stop=$nonstop" { (in the other files too, of course.) Thanks, Pedro Alves