From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48125 invoked by alias); 10 Sep 2015 13:16:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48112 invoked by uid 89); 10 Sep 2015 13:16:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Sep 2015 13:16:37 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id C827540C59; Thu, 10 Sep 2015 13:16:35 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t8ADGXJI013416; Thu, 10 Sep 2015 09:16:34 -0400 Message-ID: <55F182B1.4020404@redhat.com> Date: Thu, 10 Sep 2015 13:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Luis Machado , gdb-patches@sourceware.org Subject: Re: [PATCH] Do not pass NULL for the string in catch_errors References: <1441809933-9612-1-git-send-email-lgustavo@codesourcery.com> In-Reply-To: <1441809933-9612-1-git-send-email-lgustavo@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00163.txt.bz2 On 09/09/2015 03:45 PM, Luis Machado wrote: > I caught a segmentation fault while running gdb.reverse/sigall-reverse.exp, > in a mingw32 GDB, in this code path. It boils down to the code trying to > strlen () a NULL pointer. I tracked things down and it looks like > record_full_message_wrapper_safe is the only occurrence. > > We could also change catch_errors to check the char pointer and pass the > empty string automatically if the pointer is NULL. Then again, it seems like > catch_errors is going away at any time now, being potentially replaced > with catch_exceptions. It's been marked superseded for years. If you had fixed this by converting this one instance, we'd be a little closer. ;-) > > For now, though, the attach fix seems to accomplish the job. > > Does that look reasonable? > > gdb/ChangeLog: > > 2015-09-09 Luis Machado > > * record-full.c (record_full_message_wrapper_safe): Do not pass > NULL to string parameter in catch_errors. Sure. OK. Thanks, Pedro Alves