From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54175 invoked by alias); 9 Sep 2015 12:06:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53294 invoked by uid 89); 9 Sep 2015 12:06:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 09 Sep 2015 12:06:00 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 9459191DAA; Wed, 9 Sep 2015 12:05:59 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t89C5wBi010344; Wed, 9 Sep 2015 08:05:58 -0400 Message-ID: <55F020A5.8090604@redhat.com> Date: Wed, 09 Sep 2015 12:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Markus Metzger CC: gdb-patches@sourceware.org Subject: Re: [PATCH 09/17] btrace: resume all requested threads References: <1441794909-32718-1-git-send-email-markus.t.metzger@intel.com> <1441794909-32718-10-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1441794909-32718-10-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00126.txt.bz2 On 09/09/2015 11:35 AM, Markus Metzger wrote: > + /* For non-stop targets... */ ITYM "for all-stop". Might be worth an audit for other all-stop / non-stop flips. I think I saw a "stop-all" typo somewhere else in the series, but I can't find it right now... > + if (!target_is_non_stop_p ()) > + { > + /* ...we pick the current thread when asked to resume an entire process Thanks, Pedro Alves