From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-125883-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 121818 invoked by alias); 9 Sep 2015 11:54:24 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 121805 invoked by uid 89); 9 Sep 2015 11:54:23 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 09 Sep 2015 11:54:22 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (Postfix) with ESMTPS id C182D8B136;	Wed,  9 Sep 2015 11:54:21 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t89BsKIm001257;	Wed, 9 Sep 2015 07:54:21 -0400
Message-ID: <55F01DEC.4030209@redhat.com>
Date: Wed, 09 Sep 2015 11:54:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Markus Metzger <markus.t.metzger@intel.com>
CC: gdb-patches@sourceware.org
Subject: Re: [PATCH 13/17] btrace: non-stop
References: <1441794909-32718-1-git-send-email-markus.t.metzger@intel.com> <1441794909-32718-14-git-send-email-markus.t.metzger@intel.com>
In-Reply-To: <1441794909-32718-14-git-send-email-markus.t.metzger@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-09/txt/msg00123.txt.bz2

On 09/09/2015 11:35 AM, Markus Metzger wrote:

> +# make sure $line matches the full expected output per thread.
> +# and let's hope that GDB never mixes the output from different threads.
> +#
> +# this is quite fragile, mostly because the prompt appears somewhere in
> +# the middle of the output.
> +proc gdb_cont_to { threads cmd line nthreads } {
> +    global gdb_prompt
> +    set full_cmd "thread apply $threads $cmd"
> +    set prompt_seen 0
> +
> +    send_gdb "$full_cmd\n"
> +
> +    for {set i 0} {$i < $nthreads} {incr i} {
> +        set test "$full_cmd: thread $i"
> +
> +        # check for the prompt.  it may be in front of one of the lines we
> +        # try to match.
> +        gdb_test_multiple "" "$test: check prompt" {
> +            -notransfer -re "$gdb_prompt " {
> +                set prompt_seen 1
> +            }
> +        }
> +

Hmmm.  I'm not sure I'm missing some subtlety, but it seems to me
that if you used -notransfer, then the prompt will still be in the buffer,
and ...

> +        # check for the line.  and for a typical error.
> +        gdb_test_multiple "" $test {
> +            -re "Cannot execute this command \[^\\\r\\\n\]* is running\." {
> +                fail $test
> +            }
> +            -re "$line\[^\\\r\\\n\]*\r\n" {
> +                pass $test
> +            }
> +        }

... thus this gdb_test_multiple can trip on it and issue a fail.

Wouldn't this instead work?

        gdb_test_multiple "" $test {
            -re "Cannot execute this command \[^\\\r\\\n\]* is running\." {
                fail $test
            }
            -re "$line\[^\\\r\\\n\]*\r\n" {
                pass $test
            }
            -re "$gdb_prompt " {
                set prompt_seen 1
                exp_continue
            }
       }

Thanks,
Pedro Alves