From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53568 invoked by alias); 8 Sep 2015 19:01:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53546 invoked by uid 89); 8 Sep 2015 19:01:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 08 Sep 2015 19:01:53 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id BD.22.32596.B32DEE55; Tue, 8 Sep 2015 14:19:07 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.248.2; Tue, 8 Sep 2015 15:01:50 -0400 Subject: Re: [PATCH 1/2] [gdbserver] Rename supports_conditional_breakpoints to supports_hardware_single_step To: Yao Qi References: <1441096915-23615-1-git-send-email-yao.qi@linaro.org> <1441096915-23615-2-git-send-email-yao.qi@linaro.org> <55E74C68.8020608@ericsson.com> <86fv2p6kyw.fsf@gmail.com> CC: From: Antoine Tremblay Message-ID: <55EF309E.8080201@ericsson.com> Date: Tue, 08 Sep 2015 19:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <86fv2p6kyw.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00098.txt.bz2 On 09/08/2015 10:31 AM, Yao Qi wrote: > Antoine Tremblay writes: > > Hi Antoine, > >> Could we generalize this even more to supports_single_step like your >> next patch ? >> > > I am not sure. > >> Since I'm working on software single stepping for ARM, if this patch >> goes in I'll need to implement a supports_software_single_step and >> enable ConditionalBreakpoints for this case too... > > Nowadays, GDBserver only support conditional breakpoint for HW single > step target. Whether GDBserver support conditional breakpoint for SW > single step target is a separate issue, and we can decide this once we > have SW single step in GDBserver. > Alright then, I'll base my patchset based on your patch and most likely add a supports_software_single_step, if it's in by the time I post most likely later this week... > I believe GDBserver can compute the next instruction of $PC for SW > single step, but GDBserver execution control (target independent part) > will be more complicated if SW single step is involved in. > Execution control for software single step is already present in GDBServer and working fine as far as I know...?