From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66680 invoked by alias); 8 Sep 2015 15:21:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66670 invoked by uid 89); 8 Sep 2015 15:21:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 08 Sep 2015 15:21:52 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id D51A4C0B9886; Tue, 8 Sep 2015 15:21:50 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t88FLnDK010329; Tue, 8 Sep 2015 11:21:50 -0400 Message-ID: <55EEFD0D.9030308@redhat.com> Date: Tue, 08 Sep 2015 15:21:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Markus Metzger CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2] btrace: kernel address filtering References: <1441723403-31280-1-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1441723403-31280-1-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00094.txt.bz2 On 09/08/2015 03:43 PM, Markus Metzger wrote: > gdb/ > * nat/linux-btrace.h (struct btrace_target_info) : Remove. > * nat/linux-btrace.c: Include filestuff.h and inttypes.h. > Remove include of sys/utsname.h. > (linux_determine_kernel_ptr_bits): Remove. > (linux_determine_kernel_start): New. > (perf_event_is_kernel_addr): Remove tinfo argument. Update users. > Update check. > (perf_event_skip_bts_record): Remove tinfo argument. Update users. > (linux_enable_bts, linux_enable_pt): Remove tinfo->ptr_bits > initialization. > * x86-linux-nat.c (x86_linux_enable_btrace): Remove ptr_bits > assignment. > > gdbserver/ > * linux-low.c (linux_low_enable_btrace): Remove. > (linux_target_ops): Replace linux_low_enable_btrace with > linux_enable_btrace. LGTM. Thanks, Pedro Alves