From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38776 invoked by alias); 8 Sep 2015 08:45:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38765 invoked by uid 89); 8 Sep 2015 08:45:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 08 Sep 2015 08:45:31 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 7C925C0B9865; Tue, 8 Sep 2015 08:45:30 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t888jSMN006143; Tue, 8 Sep 2015 04:45:29 -0400 Message-ID: <55EEA028.9000000@redhat.com> Date: Tue, 08 Sep 2015 08:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi , Richard Earnshaw CC: gdb-patches@sourceware.org, pinskia@gmail.com, catalin.udma@freescale.com Subject: Re: [PATCH] aarch64-core.xml: 32-bit cpsr -> 64-bit pstate References: <1441284969-30465-1-git-send-email-yao.qi@linaro.org> <55EE13C3.6000008@foss.arm.com> <86si6p726k.fsf@gmail.com> In-Reply-To: <86si6p726k.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-09/txt/msg00084.txt.bz2 On 09/08/2015 09:20 AM, Yao Qi wrote: > > AArch64 is still a new architecture, and there isn't much compatibility > burden as other old archs have. Under the same reasoning, you should be able to fix kgdb as well. > Under this context, I think correctness > is more important than compatibility. If we don't fix it now, we can't fix > it forever. So it isn't an arbitrary change. Simply cpsr->pstate like in your patch has user-visible changes as well. Do users really expect to see "pstate" in "info registers"? If it really OK that "print $cpsr" stops working? But the change is really not OK as is. You can't have a server _not_ send "cpsr" and claim that the target description supports the "org.gnu.gdb.aarch64.core" feature: @node AArch64 Features @subsection AArch64 Features @cindex target descriptions, AArch64 features The @samp{org.gnu.gdb.aarch64.core} feature is required for AArch64 targets. It should contain registers @samp{x0} through @samp{x30}, @samp{sp}, @samp{pc}, and @samp{cpsr}. If we do go the cpsr->pstate direction, we'll have to add a new target feature. Thanks, Pedro Alves