From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40941 invoked by alias); 3 Sep 2015 07:31:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40931 invoked by uid 89); 3 Sep 2015 07:31:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 03 Sep 2015 07:31:16 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 7857F28F425C; Thu, 3 Sep 2015 09:31:14 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UgHnIIsNXnVh; Thu, 3 Sep 2015 09:31:14 +0200 (CEST) Received: from [192.168.0.53] (nat75-2-78-193-84-173.fbxo.proxad.net [78.193.84.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 17CF128F424C; Thu, 3 Sep 2015 09:31:14 +0200 (CEST) Subject: Re: [PATCH] Add proper handling for non-local references in nested functions To: Joel Brobecker References: <550C1170.9070208@adacore.com> <55685B60.3000004@redhat.com> <55775EB0.4080701@adacore.com> <55AF5F7E.5000600@adacore.com> <20150722173957.7ed51f18@pinnacle.lan> <55B0C583.6050601@adacore.com> <55BB538B.7090104@adacore.com> <55D1E2B5.4000200@adacore.com> <20150902234947.GA575@adacore.com> Cc: Doug Evans , Kevin Buettner , gdb-patches@sourceware.org From: Pierre-Marie de Rodat Message-ID: <55E7F741.70400@adacore.com> Date: Thu, 03 Sep 2015 07:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150902234947.GA575@adacore.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00051.txt.bz2 Joel, On 09/03/2015 01:49 AM, Joel Brobecker wrote: > This patch is causing a crash on some platforms, as explained by > the revision log of the attached patch. > > gdb/ChangeLog: > [...] Thank you very much for the investigation and the fix! > As also mentioned in the revision log of the patch, we can probably > do some refactoring, or perhaps a different API in the vector that > just extracts the needed data (per_cu, at the moment) from symbol's > SYMBOL_LOCATION_BATON. Then, instead of calling the method to get > the function frame_base, you have a function that gets it by using > that different symbol_block_ops function. I will give it a try and submit a patch but indeed, let's first do fix the crash first. -- Pierre-Marie de Rodat