From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 04/13] Get pid rather than lwpid
Date: Tue, 25 Aug 2015 10:47:00 -0000 [thread overview]
Message-ID: <55DC47C6.9090603@redhat.com> (raw)
In-Reply-To: <1439913199-22882-5-git-send-email-yao.qi@linaro.org>
On 08/18/2015 04:53 PM, Yao Qi wrote:
> We print PID rather than LWPID in the debug output, so we need call
> ptid_get_pid in debug_reg_change_callback.
This doesn't really make sense to me. We're changing debug registers
of an LWP, so we should print the LWP's pid, not the thread group
leader's pid.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-08-25 10:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 15:53 [PATCH 00/13] [aarch64] Share more code between GDB and GDBserver Yao Qi
2015-08-18 15:53 ` [PATCH 01/13] [gdbserver] Use iterate_over_lwps in aarch64_notify_debug_reg_change Yao Qi
2015-08-18 15:53 ` [PATCH 11/13] Make aarch64_linux_prepare_to_resume the same on GDB and GDBserver Yao Qi
2015-08-18 15:53 ` [PATCH 07/13] Make aarch64_notify_debug_reg_change " Yao Qi
2015-08-18 15:53 ` [PATCH 10/13] Add pid argument in aarch64_get_debug_reg_state Yao Qi
2015-08-18 15:53 ` [PATCH 05/13] Use phex debug_reg_change_callback Yao Qi
2015-08-18 15:53 ` [PATCH 06/13] Use debug_printf in debug_reg_change_callback Yao Qi
2015-08-18 15:53 ` [PATCH 04/13] Get pid rather than lwpid Yao Qi
2015-08-25 10:47 ` Pedro Alves [this message]
2015-08-25 13:12 ` Yao Qi
2015-08-25 13:33 ` Pedro Alves
2015-08-18 15:53 ` [PATCH 13/13] Move aarch64_linux_new_thread to nat/aarch64-linux.c Yao Qi
2015-08-18 15:53 ` [PATCH 03/13] Remove some comments in debug_reg_change_callback Yao Qi
2015-08-18 15:53 ` [PATCH 08/13] Make debug_reg_change_callback the same on GDB and GDBserver Yao Qi
2015-08-18 15:53 ` [PATCH 09/13] Move debug_reg_change_callback and aarch64_notify_debug_reg_change to nat/aarch64-linux-hw-point.c Yao Qi
2015-08-18 15:53 ` [PATCH 12/13] Move aarch64_linux_prepare_to_resume to nat/aarch64-linux.c Yao Qi
2015-08-18 15:53 ` [PATCH 02/13] Re-indent the code Yao Qi
2015-08-25 10:43 ` [PATCH 00/13] [aarch64] Share more code between GDB and GDBserver Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DC47C6.9090603@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox