Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado <lgustavo@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Mention language in compile error message
Date: Mon, 24 Aug 2015 16:20:00 -0000	[thread overview]
Message-ID: <55DB4457.7090507@codesourcery.com> (raw)
In-Reply-To: <1440011181-32004-1-git-send-email-lgustavo@codesourcery.com>

I suppose this is obvious enough that could be pushed?

On 08/19/2015 04:06 PM, Luis Machado wrote:
> This patch improves one of the compile error messages by mentioning the
> language.
>
> Before - No compiler support for this language.
> After  - No compiler support for language <language>.
>
> How does that look?
>
> gdb/ChangeLog:
>
> 2015-08-19  Luis Machado  <lgustavo@codesourcery.com>
>
> 	* compile/compile.c (compile_to_object): Mention language in
> 	error message.
> ---
>   gdb/compile/compile.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/compile/compile.c b/gdb/compile/compile.c
> index 499c530..ff68b2d 100644
> --- a/gdb/compile/compile.c
> +++ b/gdb/compile/compile.c
> @@ -491,7 +491,8 @@ compile_to_object (struct command_line *cmd, const char *cmd_string,
>
>     /* Set up instance and context for the compiler.  */
>     if (current_language->la_get_compile_instance == NULL)
> -    error (_("No compiler support for this language."));
> +    error (_("No compiler support for language %s."),
> +	   current_language->la_name);
>     compiler = current_language->la_get_compile_instance ();
>     cleanup = make_cleanup (cleanup_compile_instance, compiler);
>
>


  reply	other threads:[~2015-08-24 16:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19 19:06 Luis Machado
2015-08-24 16:20 ` Luis Machado [this message]
2015-08-24 17:20 ` Pedro Alves
2015-08-27  5:05   ` Luis Machado
2015-10-26  3:47     ` [obv] Fix compile.exp error message expectation [Re: [PATCH] Mention language in compile error message] Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DB4457.7090507@codesourcery.com \
    --to=lgustavo@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox