From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-125571-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 107831 invoked by alias); 24 Aug 2015 16:11:04 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 107822 invoked by uid 89); 24 Aug 2015 16:11:03 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Aug 2015 16:11:01 +0000
Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43])	by relay1.mentorg.com with esmtp 	id 1ZTuKo-00060K-Ur from Luis_Gustavo@mentor.com ; Mon, 24 Aug 2015 09:10:58 -0700
Received: from [172.30.14.237] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.224.2; Mon, 24 Aug 2015 09:10:58 -0700
Message-ID: <55DB420B.70707@codesourcery.com>
Date: Mon, 24 Aug 2015 16:11:00 -0000
From: Luis Machado <lgustavo@codesourcery.com>
Reply-To: Luis Machado <lgustavo@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Prevent GCC from folding inline test functions
References: <1440162341-26343-1-git-send-email-lgustavo@codesourcery.com> <55D74BCE.5020206@redhat.com> <55DB3CE1.7020402@codesourcery.com> <55DB3E15.2080402@redhat.com> <55DB3F45.4030602@codesourcery.com> <55DB412D.6040807@redhat.com>
In-Reply-To: <55DB412D.6040807@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-08/txt/msg00686.txt.bz2

On 08/24/2015 01:07 PM, Pedro Alves wrote:
> On 08/24/2015 04:59 PM, Luis Machado wrote:
>> On 08/24/2015 12:53 PM, Pedro Alves wrote:
>>> On 08/24/2015 04:48 PM, Luis Machado wrote:
>>>> --- a/gdb/testsuite/gdb.opt/inline-markers.c
>>>> +++ b/gdb/testsuite/gdb.opt/inline-markers.c
>>>> @@ -13,7 +13,7 @@
>>>>       You should have received a copy of the GNU General Public License
>>>>       along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
>>>>
>>>> -extern int x, y;
>>>> +extern int x, y, z;
>>>
>>> z here should match the definition (should be volatile here too).
>>>
>>> Thanks,
>>> Pedro Alves
>>>
>>
>> Fixed with 91dddb86299bba404599551e9e2633b3c0e5c830.
>>
>
> Thanks.  Though,
>
>   -extern int x, y, z;
>   +extern int x, y;
>   +extern volatile z;
>
> I think this will cause trouble with newer gcc that default
> to gnu c11.  Since C99 that a missing type specifier is no
> longer implicitly assumed to be int.  Thus that should really be:
>
> extern volatile int z;
>
> Thanks,
> Pedro Alves
>

Fixed in 4422ac93e5d3d23dd441aadaa49c81356aa59b73.