From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127992 invoked by alias); 21 Aug 2015 18:04:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127977 invoked by uid 89); 21 Aug 2015 18:04:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 21 Aug 2015 18:04:30 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 587208E907; Fri, 21 Aug 2015 18:04:29 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7LI4Rrp012422; Fri, 21 Aug 2015 14:04:28 -0400 Message-ID: <55D7682B.5050805@redhat.com> Date: Fri, 21 Aug 2015 18:04:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] tui: don't overwrite a subprompt line that was given no input References: <1440175538-8021-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1440175538-8021-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-08/txt/msg00586.txt.bz2 On 08/21/2015 05:45 PM, Patrick Palka wrote: > This patch fixes the following bug in TUI: > > (gdb) break foo > No symbol table is loaded. Use the "file" command. > Make breakpoint pending on future shared library load? (y or [n]) > > By submitting an empty command line to a subprompt, the subprompt line > is undesirably cleared and overwritten. Outside of a subprompt, > clearing the prompt line after submitting an empty command line is > intended behavior which complements GDB's repeat-command shorthand. But > inside a subprompt, this behavior is undesired since the shorthand is > not applicable in that case. We should retain the subprompt line even > when it's given to input. > > This patch makes sure that a prompt given an empty command line is > cleared and overwritten only if it's not a subprompt. To acheive this, > a new predicate is defined which informs us whether the current input > handler is a subprompt. > > gdb/ChangeLog: > > * top.h (gdb_in_subprompt_p): Declare. > * top.c (gdb_subprompt_depth): Define. > (gdb_in_subprompt_p): Define. > (gdb_readline_wrapper_cleanup): Decrement gdb_subprompt_depth. > (gdb_readline_wrapper): Increment gdb_subprompt_depth. > * tui/tui-io.c (tui_getc): Don't clear the prompt line if we > are in a subprompt. OK, but should really be s/subprompt/secondary prompt/ everywhere. Thanks, Pedro Alves