Re: [PATCH 2/2] Make remote file transfers interruptible

Gary Benson
2015-08-11T10:52:27Z

Hi Sandra,

Sandra Loosemore wrote:
> On 08/05/2015 09:28 AM, Gary Benson wrote:
> > This commit makes it possible to interrupt slow remote file transfers.
> >
> > gdb/ChangeLog:
> >
> > * gdb_bfd.c (gdb_bfd_iovec_fileio_pread): Add QUIT call.
>
> I think that this is the same patch that you sent earlier:
>
> https://sourceware.org/ml/gdb/2015-07/msg00043.html
>
> It still does not work for me. :-(

Ok, given the packet-size limit of RSP I was assuming GDB would read
the files in chunks the size of the server's packet buffer size (16k
for gdbserver) but it seems that that chunking happens at a lower
level, so the interrupt is only noticed between files rather than
between chunks. I tested this patch using "remote get", but it seems
that that operates differently. So I'm retracting this patch.

Making remote transfers properly interruptible looks like a fairly
involved task that's only slightly on my radar. I've filed a bug
(https://sourceware.org/bugzilla/show_bug.cgi?id=18804) to keep the
issue from being forgotten. I'll work on if I have some free time,
or someone else can do it.

The other patch in the series (the warning messages) can go in if
people find it useful.

Thanks,
Gary

--